You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@giraph.apache.org by GitBox <gi...@apache.org> on 2019/11/19 02:17:42 UTC

[GitHub] [giraph] dlogothetis commented on a change in pull request #114: Upgrade Netty to 4.1.36

dlogothetis commented on a change in pull request #114: Upgrade Netty to 4.1.36
URL: https://github.com/apache/giraph/pull/114#discussion_r347702963
 
 

 ##########
 File path: giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java
 ##########
 @@ -335,6 +333,10 @@ protected void initChannel(SocketChannel ch) throws Exception {
             if (conf.authenticate()) {
               LOG.info("Using Netty with authentication.");
 
+              PipelineUtils.addLastWithExecutorCheck("flushConsolidation",
+                new FlushConsolidationHandler(FlushConsolidationHandler
+                  .DEFAULT_EXPLICIT_FLUSH_AFTER_FLUSHES, true),
+                handlerToUseExecutionGroup, executionGroup, ch);
 
 Review comment:
   Looking around on netty related posts, it seems this is good practice as it batches small flushes into bigger ones for efficiency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services