You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "guoqqqi (via GitHub)" <gi...@apache.org> on 2023/03/07 14:02:48 UTC

[GitHub] [apisix-dashboard] guoqqqi commented on a diff in pull request #2762: fix: change regex template to optional in proxy write

guoqqqi commented on code in PR #2762:
URL: https://github.com/apache/apisix-dashboard/pull/2762#discussion_r1127908892


##########
web/src/pages/Route/components/Step1/ProxyRewrite.tsx:
##########
@@ -100,14 +100,6 @@ const ProxyRewrite: React.FC<RouteModule.Step1PassProps> = ({ form, disabled })
                         label={formatMessage({ id: 'page.route.form.itemLabel.template' })}
                         name={field.name}
                         key={field.name}
-                        rules={[

Review Comment:
   Just to confirm, this change doesn't require a change to the API interface?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org