[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #13013: [Fix-12981]add worker address validator and clear function.

[GitBox <gi...@apache.org>]

DarkAssassinator commented on code in PR #13013:
URL: https://github.com/apache/dolphinscheduler/pull/13013#discussion_r1037000608


##########
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/NetUtilsTest.java:
##########
@@ -115,4 +115,40 @@ public void testIsValidAddress() {
         Assertions.assertFalse(NetUtils.isValidV4Address(address));
     }
 
+    @Test
+    public void giveIpAddress_thenCheckIsValidIPv4Address_thenCheck_expectNormal() {
+        Assertions.assertFalse(NetUtils.isValidIPv4Address(""));
+
+        String ipAddress = "127.0.0.1";

Review Comment:
   > > sure, but the format of the `host` is too broad, i want to just add a fuzzy check. WDYT.
   > 
   > What kind of fuzzy check?
   
   such as just `string:port`, BTW, may we can rollback these validator, because this validator just for filter `default`, under normal circumstances, there should be no other illegal worker configurations. WDYT. cc @caishunfeng @ruanwenjun @Radeity 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org