You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/04/21 09:16:59 UTC

[GitHub] [carbondata] akkio-97 opened a new pull request #3722: changes to reflect default behaviour in case of invalid configuration…

akkio-97 opened a new pull request #3722:
URL: https://github.com/apache/carbondata/pull/3722


   … values
   
    ### Why is this PR needed?
    Invalid configuration values in carbon.properties causes operation failure instead of reflecting default configuration value behaviour.
    
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3722: [CARBONDATA-3782] changes to reflect default behaviour in case of invalid configuration…

Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3722:
URL: https://github.com/apache/carbondata/pull/3722#issuecomment-618386458


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2825/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3722: [CARBONDATA-3782] changes to reflect default behaviour in case of invalid configuration…

Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3722:
URL: https://github.com/apache/carbondata/pull/3722#issuecomment-618385887


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1112/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3722: [CARBONDATA-3782] changes to reflect default behaviour in case of invalid configuration…

Posted by GitBox <gi...@apache.org>.
akkio-97 commented on a change in pull request #3722:
URL: https://github.com/apache/carbondata/pull/3722#discussion_r413691071



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
##########
@@ -135,7 +136,8 @@ class NewCarbonDataLoadRDD[K, V](
 
         val preFetch = CarbonProperties.getInstance().getProperty(CarbonCommonConstants
           .USE_PREFETCH_WHILE_LOADING, CarbonCommonConstants.USE_PREFETCH_WHILE_LOADING_DEFAULT)
-        carbonLoadModel.setPreFetch(preFetch.toBoolean)
+        carbonLoadModel.setPreFetch(Try(preFetch.toBoolean).getOrElse((CarbonCommonConstants

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akashrn5 commented on pull request #3722: [CARBONDATA-3782] changes to reflect default behaviour in case of invalid configuration…

Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #3722:
URL: https://github.com/apache/carbondata/pull/3722#issuecomment-618805528


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3722: [CARBONDATA-3782] changes to reflect default behaviour in case of invalid configuration…

Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3722:
URL: https://github.com/apache/carbondata/pull/3722#discussion_r413620750



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
##########
@@ -135,7 +136,8 @@ class NewCarbonDataLoadRDD[K, V](
 
         val preFetch = CarbonProperties.getInstance().getProperty(CarbonCommonConstants
           .USE_PREFETCH_WHILE_LOADING, CarbonCommonConstants.USE_PREFETCH_WHILE_LOADING_DEFAULT)
-        carbonLoadModel.setPreFetch(preFetch.toBoolean)
+        carbonLoadModel.setPreFetch(Try(preFetch.toBoolean).getOrElse((CarbonCommonConstants

Review comment:
       remove unnecessary brackets for `(CarbonCommonConstants
             .USE_PREFETCH_WHILE_LOADING_DEFAULT).toBoolean`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3722: changes to reflect default behaviour in case of invalid configuration…

Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3722:
URL: https://github.com/apache/carbondata/pull/3722#issuecomment-617123238


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2806/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3722: changes to reflect default behaviour in case of invalid configuration…

Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3722:
URL: https://github.com/apache/carbondata/pull/3722#issuecomment-617113492


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1094/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org