[GitHub] [incubator-doris] morningman commented on a change in pull request #7210: [feat](flink-connector) add BATCH DELETE support

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7210:
URL: https://github.com/apache/incubator-doris/pull/7210#discussion_r755802527



##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -105,6 +111,25 @@ public Builder setStreamLoadProp(Properties streamLoadProp) {
             return this;
         }
 
+        public Builder setJsonFormat() {
+            this.streamLoadProp.setProperty("format", "json");
+            this.streamLoadProp.setProperty("strip_outer_array", "true");

Review comment:
       the `strip_outer_array` is not always true. This should leave to user to decide.
   
   And you don' t need to open another PR to modify this code. You can just push a new commit to your own branch
   `feature_add_batch_delete_support`, and Github will automatically sync that commit to this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org