You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/05/02 06:26:08 UTC

[jira] [Commented] (MAPREDUCE-4330) TaskAttemptCompletedEventTransition invalidates previously successful attempt without checking if the newly completed attempt is successful

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524612#comment-14524612 ] 

Hadoop QA commented on MAPREDUCE-4330:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12578792/MAPREDUCE-4330-20130415.1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5511/console |


This message was automatically generated.

> TaskAttemptCompletedEventTransition invalidates previously successful attempt without checking if the newly completed attempt is successful
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4330
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4330
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.23.1
>            Reporter: Bikas Saha
>            Assignee: Omkar Vinit Joshi
>         Attachments: MAPREDUCE-4330-20130415.1.patch, MAPREDUCE-4330-20130415.patch, MAPREDUCE-4330-21032013.1.patch, MAPREDUCE-4330-21032013.patch
>
>
> The previously completed attempt is removed from successAttemptCompletionEventNoMap and marked OBSOLETE.
> After that, if the newly completed attempt is successful then it is added to the successAttemptCompletionEventNoMap. 
> This seems wrong because the newly completed attempt could be failed and thus there is no need to invalidate the successful attempt.
> One error case would be when a speculative attempt completes with killed/failed after the successful version has completed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)