You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "sfc-gh-swalia (via GitHub)" <gi...@apache.org> on 2026/07/27 19:53:54 UTC

[PR] Updating CI Actions path [ossie]

sfc-gh-swalia opened a new pull request, #276:
URL: https://github.com/apache/ossie/pull/276

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   ## Summary
   
   While working on PR #259, I noticed that all 8 converter CI workflows use .github/** as a path trigger. This means any PR that touches anything under ```.github/``` triggers every converter's test suite unnecessarily. 
   
   This wastes CI resources and creates confusing failures on unrelated PRs (e.g., #259 showed a failing Omni build that had nothing to do with the docs changes).
   
   This fix narrows each workflow's path filter to only reference its own workflow file, so a converter's CI only runs when its converter code or its own workflow definition changes.
   
   ## Related Issues
   
   #259
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Updating CI Actions path [ossie]

Posted by "sfc-gh-swalia (via GitHub)" <gi...@apache.org>.
sfc-gh-swalia commented on PR #276:
URL: https://github.com/apache/ossie/pull/276#issuecomment-5096151482

   @khush-bhatia @jbonofre adding this PR since I noticed CI failing for #259. LMK what you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Updating CI Actions path [ossie]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #276:
URL: https://github.com/apache/ossie/pull/276


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Updating CI Actions path [ossie]

Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on PR #276:
URL: https://github.com/apache/ossie/pull/276#issuecomment-5099802410

   > @khush-bhatia @jbonofre adding this PR since I noticed CI failing for #259. LMK what you think.
   
   Hello @sfc-gh-swalia,
   
   Yes, this was implicitly added by me. The original idea is if there are composite actions (e.g. license , we should re-test all. I am fine with keep it restrict as one failure will now trigger all PR to halt.
   
   Thanks,
   Yong Zheng


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Updating CI Actions path [ossie]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #276:
URL: https://github.com/apache/ossie/pull/276#issuecomment-5100276068

   The failing check here (**Converters Omni CI / build (3.11)**) is not caused by this PR — it's a pre-existing bug on `main` that this PR merely exposes.
   
   **What fails:** two Omni tests, both on a dropped `datatype` field:
   - `tests/test_roundtrip.py::test_osi_roundtrip_up_to_documented_normalizations[.../tpcds_semantic_model.yaml]`
   - `tests/test_osi_to_omni.py::test_tpcds_export_matches_expected`
   
   **Root cause:** #113 added the `datatype` field to `Field`/`Metric` and to `examples/tpcds_semantic_model.yaml`, but it did not update `converters/omni` (grep for `datatype` there returns nothing). So on the OSI → Omni → OSI roundtrip, `datatype` is silently dropped and the result no longer matches the original.
   
   **Why it surfaces now:** #113 touched neither `converters/omni/**` nor `.github/**`, so Omni CI never ran for it and the regression slipped in. This PR edits `converter-omni-ci.yml` itself, which triggers Omni CI and reveals the latent breakage.
   
   This PR's CI-path change is correct. Could we get a separate fix to teach the Omni converter to carry `datatype` through the OSI↔Omni conversion (and refresh the `tpcds_omni` fixture)? That would get this check green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org