You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/22 16:54:41 UTC

[jira] [Commented] (METRON-792) Quick Dev should remove/replace RPM packages

    [ https://issues.apache.org/jira/browse/METRON-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936677#comment-15936677 ] 

ASF GitHub Bot commented on METRON-792:
---------------------------------------

GitHub user dlyle65535 opened a pull request:

    https://github.com/apache/incubator-metron/pull/487

    METRON-792: Quick Dev should remove/replace RPM packages

    ## Contributor Comments
    While building out METRON-671, I inadvertently omitted recreation of the RPM database for Quick Dev. As a result, stale RPMs are installed so, Quick Dev removes and then re-installs the same bits. 
    
    This fixes that. Now it clears out /localrepo and re-runs createrepo.
    
    To test:
    
    - Merge this PR
    - Run _vagrant up_ from _project directory/metron-deployment/vagrant/quick-dev-platform_. 
    - Once deployment is complete, _vagrant ssh_ to node1.
    _project directory/metron-deployment/vagrant/quick-dev-platform_. 
    - Once deployment is complete, _vagrant ssh_ to node1.
    - Verify that the RPMs in /localrepo are timestamped the same as those in _project directory/metron-deployment/packaging/docker/rpm-docker/RPMS/noarch_
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron (Incubating).  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [N/A] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [X] Have you included steps or a guide to how the change may be verified and tested manually?
    - [X] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [N/A] Have you written or updated unit tests and or integration tests to verify your changes?
    - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [X] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [N/A] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      bin/generate-md.sh
      mvn site:site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommened that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlyle65535/incubator-metron METRON-792

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/487.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #487
    
----
commit f8e8e999096aa6963fa1ca96e186c14320afbc43
Author: David Lyle <dl...@gmail.com>
Date:   2017-03-22T16:46:48Z

    METRON-792: Quick Dev should remove/replace RPM packages

----


> Quick Dev should remove/replace RPM packages
> --------------------------------------------
>
>                 Key: METRON-792
>                 URL: https://issues.apache.org/jira/browse/METRON-792
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.3.1
>            Reporter: David M. Lyle
>            Assignee: David M. Lyle
>             Fix For: Next + 1
>
>
> Currently, quick_dev removes and re-installs Metron at the Ambari level only, it must also remove and replace the RPMs in /localdev.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)