You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/11 09:03:26 UTC

[GitHub] [ozone] navinko opened a new pull request, #3819: HDDS-7308. Updated Doc for OM HA Setup

navinko opened a new pull request, #3819:
URL: https://github.com/apache/ozone/pull/3819

   ## What changes were proposed in this pull request?
   
   Removed serviceIds 'cluster2' from ozone.om.service.ids configuration since it's not being used and creating confusion/doubts.
   property>
      <name>ozone.om.service.ids</name>
      <value>cluster1,cluster2</value>
   </property>
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-7308
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on a diff in pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3819:
URL: https://github.com/apache/ozone/pull/3819#discussion_r994218467


##########
hadoop-hdds/docs/content/feature/OM-HA.zh.md:
##########
@@ -58,7 +58,7 @@ Ozone Manager 和 Storage Container Manager 都支持 HA。在这种模式下，
  ```

Review Comment:
   @adoroszlai , sorry,  didn't refresh the page and notice your comments.  Let mark this and try to correct the style next time.   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] navinko commented on a diff in pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
navinko commented on code in PR #3819:
URL: https://github.com/apache/ozone/pull/3819#discussion_r994218400


##########
hadoop-hdds/docs/content/feature/OM-HA.md:
##########
@@ -56,7 +56,7 @@ This logical name is called `serviceId` and can be configured in the `ozone-site
  ```

Review Comment:
   resolved



##########
hadoop-hdds/docs/content/feature/OM-HA.zh.md:
##########
@@ -58,7 +58,7 @@ Ozone Manager 和 Storage Container Manager 都支持 HA。在这种模式下，
  ```

Review Comment:
   resolved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi merged pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
ChenSammi merged PR #3819:
URL: https://github.com/apache/ozone/pull/3819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on a diff in pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3819:
URL: https://github.com/apache/ozone/pull/3819#discussion_r994218467


##########
hadoop-hdds/docs/content/feature/OM-HA.zh.md:
##########
@@ -58,7 +58,7 @@ Ozone Manager 和 Storage Container Manager 都支持 HA。在这种模式下，
  ```

Review Comment:
   @adoroszlai , sorry,  didn't refresh the page and notice your comments.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] navinko commented on a diff in pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
navinko commented on code in PR #3819:
URL: https://github.com/apache/ozone/pull/3819#discussion_r994222895


##########
hadoop-hdds/docs/content/feature/OM-HA.md:
##########
@@ -56,7 +56,7 @@ This logical name is called `serviceId` and can be configured in the `ozone-site
  ```

Review Comment:
   @adoroszlai Thank you for suggestion, will raise another PR 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on a diff in pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3819:
URL: https://github.com/apache/ozone/pull/3819#discussion_r994176894


##########
hadoop-hdds/docs/content/feature/OM-HA.zh.md:
##########
@@ -58,7 +58,7 @@ Ozone Manager 和 Storage Container Manager 都支持 HA。在这种模式下，
  ```

Review Comment:
   Same here:
   
   ```suggestion
   ```XML
   ```



##########
hadoop-hdds/docs/content/feature/OM-HA.md:
##########
@@ -56,7 +56,7 @@ This logical name is called `serviceId` and can be configured in the `ozone-site
  ```

Review Comment:
   This code block looks different in the [rendered doc](https://ozone.apache.org/docs/1.2.1/feature/om-ha.html#configuration).  The problem is not introduced by this patch, but since you are already making a change here, can you please fix it?
   
   ```suggestion
   ```XML
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] navinko commented on pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
navinko commented on PR #3819:
URL: https://github.com/apache/ozone/pull/3819#issuecomment-1277035327

   Thanks @ChenSammi for reviewing .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3819:
URL: https://github.com/apache/ozone/pull/3819#issuecomment-1277030758

   LGTM + 1.  Thanks @navinko . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] navinko commented on a diff in pull request #3819: HDDS-7308. Updated Doc for OM HA Setup

Posted by GitBox <gi...@apache.org>.
navinko commented on code in PR #3819:
URL: https://github.com/apache/ozone/pull/3819#discussion_r994223827


##########
hadoop-hdds/docs/content/feature/OM-HA.zh.md:
##########
@@ -58,7 +58,7 @@ Ozone Manager 和 Storage Container Manager 都支持 HA。在这种模式下，
  ```

Review Comment:
   Thanks @ChenSammi @adoroszlai for reviewing . I will open another PR for XML formatting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org