You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2025/11/06 19:50:52 UTC
[PR] refactor(mcp): shorten tool name from get_superset_instance_info to get_instance_info [superset]
aminghadersohi opened a new pull request, #36032:
URL: https://github.com/apache/superset/pull/36032
### SUMMARY
Renames the MCP tool from `get_superset_instance_info` to `get_instance_info` to reduce verbosity while maintaining clarity.
**Rationale**: The `superset` prefix in the tool name is redundant since all MCP tools operate within the Superset context. Shorter tool names improve the developer experience and reduce token usage when AI assistants interact with the MCP service.
**Changes**:
- Renamed tool file: `get_superset_instance_info.py` → `get_instance_info.py`
- Updated function name: `get_superset_instance_info` → `get_instance_info`
- Updated all imports and references across:
- `superset/mcp_service/app.py` (tool imports and documentation)
- `superset/mcp_service/system/tool/__init__.py` (module exports)
- `superset/mcp_service/system/schemas.py` (docstring)
- `superset/mcp_service/system/resources/instance_metadata.py` (import and usage tip)
- `superset/mcp_service/system/prompts/quickstart.py` (documentation)
**Design Decision**: Only the tool name changes - the schema class name `GetSupersetInstanceInfoRequest` remains unchanged to avoid breaking changes to existing integrations that might reference the schema type.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - This is a backend refactor with no UI changes.
### TESTING INSTRUCTIONS
1. **Start the MCP service**:
```bash
superset mcp run --port 5008
```
2. **Test tool listing** (verify new name appears):
```bash
# Using MCP inspector or Claude Desktop
# Verify tool name shows as "get_instance_info"
```
3. **Test tool execution** (verify functionality unchanged):
```bash
# Call get_instance_info via MCP client
# Verify it returns instance statistics as before
```
4. **Verify documentation updates**:
- Check `DEFAULT_INSTRUCTIONS` in `app.py` mentions `get_instance_info`
- Check quickstart prompt references `get_instance_info`
- Check instance metadata resource tips mention `get_instance_info`
### ADDITIONAL INFORMATION
- [ ] Has associated issue: N/A
- [ ] Required feature flags: None
- [ ] Changes UI: No
- [ ] Includes DB Migration: No
- [ ] Introduces new feature or API: No
- [ ] Removes existing feature or API: No (renamed only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(mcp): shorten tool name from get_superset_instance_info to get_instance_info [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36032:
URL: https://github.com/apache/superset/pull/36032#issuecomment-3499140040
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(mcp): shorten tool name from get_superset_instance_info to get_instance_info [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #36032:
URL: https://github.com/apache/superset/pull/36032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(mcp): shorten tool name from get_superset_instance_info to get_instance_info [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36032:
URL: https://github.com/apache/superset/pull/36032#issuecomment-3499176671
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/36032?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.48%. Comparing base ([`76d897e`](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7d3533e`](https://app.codecov.io/gh/apache/superset/commit/7d3533e5269b18d2c45ce9ac52eb34ecec73c0f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2852 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #36032 +/- ##
===========================================
- Coverage 60.48% 48.48% -12.01%
===========================================
Files 1931 622 -1309
Lines 76236 45717 -30519
Branches 8568 4975 -3593
===========================================
- Hits 46114 22165 -23949
+ Misses 28017 22927 -5090
+ Partials 2105 625 -1480
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/36032/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/36032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.20% <ø> (-4.95%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/36032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/36032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.76% <ø> (-6.04%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/36032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (-15.03%)` | :arrow_down: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/36032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+42.36%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/36032?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org