You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Le Ma <co...@gmail.com> on 2019/10/25 17:34:02 UTC

Re: Review Request 71612: ATLAS-3457 Support Multi-Classification search without attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71612/
-----------------------------------------------------------

(Updated Oct. 25, 2019, 5:34 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.


Changes
-------

Rebase codebase and resolve comments


Bugs: ATLAS-3457
    https://issues.apache.org/jira/browse/ATLAS-3457


Repository: atlas


Description
-------

support multi-classification


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7a2aae2e9 
  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 672f38132 
  repository/src/main/java/org/apache/atlas/discovery/GraphIndexQueryBuilder.java 3f58acb9c 
  repository/src/main/java/org/apache/atlas/discovery/MultiClassificationSearchProcessor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 7ad32bdb9 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java b56d8e83a 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 908ae7033 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cd8f8981c 


Diff: https://reviews.apache.org/r/71612/diff/5/

Changes: https://reviews.apache.org/r/71612/diff/4-5/


Testing
-------

- Search related tests passed. 
- added unit tests, it passed.
- Pre-commit job passed. https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1471/


Thanks,

Le Ma