You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/20 01:43:49 UTC
[GitHub] [cordova-android] erisu opened a new pull request #902: chore:
remove .project file & add .settings to gitignore
erisu opened a new pull request #902: chore: remove .project file & add .settings to gitignore
URL: https://github.com/apache/cordova-android/pull/902
### Motivation and Context
Remove noise from the git status & diff.
### Description
* Removed `framework/.project`
This file is on the `.gitignore` list but not acknowledged as exists in the repo. Since this file is generated by the editor, it can be removed from repo as it will be regenerated locally.
* Added `.settings` to the `.gitignore` list
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #902: chore: remove
.project file & add .settings to gitignore
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #902: chore: remove .project file & add .settings to gitignore
URL: https://github.com/apache/cordova-android/pull/902#issuecomment-576075354
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=h1) Report
> Merging [#902](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/60e022feddfae0c585cafe500e74ab5d52381e74?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #902 +/- ##
=======================================
Coverage 66.17% 66.17%
=======================================
Files 19 19
Lines 1839 1839
=======================================
Hits 1217 1217
Misses 622 622
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=footer). Last update [60e022f...70434d5](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #902: chore: remove
.project file & add .settings to gitignore
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #902: chore: remove .project file & add .settings to gitignore
URL: https://github.com/apache/cordova-android/pull/902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #902: chore:
remove .project file & add .settings to gitignore
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #902: chore: remove .project file & add .settings to gitignore
URL: https://github.com/apache/cordova-android/pull/902#issuecomment-576075354
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=h1) Report
> Merging [#902](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/60e022feddfae0c585cafe500e74ab5d52381e74?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #902 +/- ##
=======================================
Coverage 66.17% 66.17%
=======================================
Files 19 19
Lines 1839 1839
=======================================
Hits 1217 1217
Misses 622 622
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=footer). Last update [60e022f...70434d5](https://codecov.io/gh/apache/cordova-android/pull/902?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org