You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li xu <le...@gmail.com> on 2011/06/01 22:20:13 UTC
Re: Review Request: Create default AuthorityProvider to support host/port
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
-----------------------------------------------------------
(Updated 2011-06-01 20:20:12.988099)
Review request for shindig.
Changes
-------
replace %host% with %authority% for properties replaced on server side in container.js. thanks.
Summary
-------
This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
As discussed, default AuthorityProvider would implement following logic with a Provider pattern
1. shindig.host & shindig.port defined in web.xml or system property
2. host/port from HttpServletRequest
3. Jetty host/port
link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1125049
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1125049
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/AuthorityProvider.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1124991
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/AuthorityProviderTest.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1124991
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1126359
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1124991
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1124991
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1126359
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1124991
Diff: https://reviews.apache.org/r/792/diff
Testing
-------
Thanks,
li
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by li xu <le...@gmail.com>.
> On 2011-06-04 17:26:46, Henry Saputra wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java, line 1
> > <https://reviews.apache.org/r/792/diff/3/?file=20486#file20486line1>
> >
> > ASF license
done
> On 2011-06-04 17:26:46, Henry Saputra wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java, line 4
> > <https://reviews.apache.org/r/792/diff/3/?file=20486#file20486line4>
> >
> > Needs comment about what this interface is for.
done
> On 2011-06-04 17:26:46, Henry Saputra wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, line 1
> > <https://reviews.apache.org/r/792/diff/3/?file=20487#file20487line1>
> >
> > Add ASF license header
done
> On 2011-06-04 17:26:46, Henry Saputra wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, line 9
> > <https://reviews.apache.org/r/792/diff/3/?file=20487#file20487line9>
> >
> > Needs comment about what this class is for.
done
> On 2011-06-04 17:26:46, Henry Saputra wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, line 17
> > <https://reviews.apache.org/r/792/diff/3/?file=20487#file20487line17>
> >
> > indentation seems to be incorrect?
I tried to make it align on the left with the previous parameter in Eclipse IDE.
Just like this function in DefaultGuiceModule...
protected List<String> defaultFeatures(@Named("shindig.features.default")String features,
@Named("org.apache.shindig.features-extended")Set<String> extended) {
I also see this style in other java code.
still need 2 space here?
- li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/#review762
-----------------------------------------------------------
On 2011-06-06 14:45:37, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/792/
> -----------------------------------------------------------
>
> (Updated 2011-06-06 14:45:37)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
>
> As discussed, default AuthorityProvider would implement following logic with a Provider pattern
>
> 1. shindig.host & shindig.port defined in web.xml or system property
> 2. host/port from HttpServletRequest
> 3. Jetty host/port
>
> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686
>
> Diff: https://reviews.apache.org/r/792/diff
>
>
> Testing
> -------
>
> built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/#review762
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java
<https://reviews.apache.org/r/792/#comment1628>
ASF license
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java
<https://reviews.apache.org/r/792/#comment1627>
Needs comment about what this interface is for.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java
<https://reviews.apache.org/r/792/#comment1631>
Add ASF license header
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java
<https://reviews.apache.org/r/792/#comment1629>
Needs comment about what this class is for.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java
<https://reviews.apache.org/r/792/#comment1630>
indentation seems to be incorrect?
- Henry
On 2011-06-03 21:37:58, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/792/
> -----------------------------------------------------------
>
> (Updated 2011-06-03 21:37:58)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
>
> As discussed, default AuthorityProvider would implement following logic with a Provider pattern
>
> 1. shindig.host & shindig.port defined in web.xml or system property
> 2. host/port from HttpServletRequest
> 3. Jetty host/port
>
> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686
>
> Diff: https://reviews.apache.org/r/792/diff
>
>
> Testing
> -------
>
> built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/#review2058
-----------------------------------------------------------
I'm confused. It looks like some other OAuth related changes were included with this patch. I also don't understand why the %authority% changes are being reverted. Li, can you clarify please.
- Stanton
On 2011-09-23 19:48:55, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/792/
> -----------------------------------------------------------
>
> (Updated 2011-09-23 19:48:55)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
>
> As discussed, default AuthorityProvider would implement following logic with a Provider pattern
>
> 1. shindig.host & shindig.port defined in web.xml or system property
> 2. host/port from HttpServletRequest
> 3. Jetty host/port
>
> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_facebook.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_windowslive.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/shindig_client_credentials.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AuthType.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/XhrwrapperConfigContributor.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfig.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContext.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Request.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BasicAuthenticationHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BearerTokenHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/ClientCredentialsGrantTypeHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeAuthorizationResponseHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeGrantTypeHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/OAuth2HandlerModule.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/StandardAuthenticationHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/TokenAuthorizationResponseHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheException.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionException.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceException.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCache.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypter.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModule.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/BasicOAuth2Message.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/OAuth2MessageModule.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/AuthTypeTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultInvalidationServiceTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriteModuleTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/pom.xml 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java 1173772
>
> Diff: https://reviews.apache.org/r/792/diff
>
>
> Testing
> -------
>
> built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Henry Saputra <he...@gmail.com>.
Please open new JIRA and reviews. I think its harder to review the old patch.
- Henry
On Fri, Sep 23, 2011 at 12:48 PM, li xu <le...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/792/
> -----------------------------------------------------------
>
> (Updated 2011-09-23 19:48:55.195325)
>
>
> Review request for shindig.
>
>
> Changes
> -------
>
> This is another patch from Adam. Please find feature below:
> 1) Created against the 20110923 Shindig trunk
> 2) More error handling and reporting improvements
> 3) Tested against Windows Live with new Windows Live test gadget
> 4) Tested against IBM Tivoli Federated Identity Manager 6.2.2 beta
> 5) (Theoretical) support for "mac" token type (draft version 5) and hmac_sha_1 signing**
>
>
> Summary
> -------
>
> This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
>
> As discussed, default AuthorityProvider would implement following logic with a Provider pattern
>
> 1. shindig.host & shindig.port defined in web.xml or system property
> 2. host/port from HttpServletRequest
> 3. Jetty host/port
>
> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>
>
> Diffs (updated)
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_facebook.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_windowslive.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/shindig_client_credentials.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AuthType.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/XhrwrapperConfigContributor.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfig.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContext.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Request.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BasicAuthenticationHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BearerTokenHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/ClientCredentialsGrantTypeHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeAuthorizationResponseHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeGrantTypeHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/OAuth2HandlerModule.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/StandardAuthenticationHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/TokenAuthorizationResponseHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheException.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionException.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceException.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCache.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypter.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModule.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/BasicOAuth2Message.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/OAuth2MessageModule.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/AuthTypeTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultInvalidationServiceTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriteModuleTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/pom.xml 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1173772
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java 1173772
>
> Diff: https://reviews.apache.org/r/792/diff
>
>
> Testing
> -------
>
> built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
-----------------------------------------------------------
(Updated 2011-09-23 19:48:55.195325)
Review request for shindig.
Changes
-------
This is another patch from Adam. Please find feature below:
1) Created against the 20110923 Shindig trunk
2) More error handling and reporting improvements
3) Tested against Windows Live with new Windows Live test gadget
4) Tested against IBM Tivoli Federated Identity Manager 6.2.2 beta
5) (Theoretical) support for "mac" token type (draft version 5) and hmac_sha_1 signing**
Summary
-------
This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
As discussed, default AuthorityProvider would implement following logic with a Provider pattern
1. shindig.host & shindig.port defined in web.xml or system property
2. host/port from HttpServletRequest
3. Jetty host/port
link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json 1173772
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_facebook.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_windowslive.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/shindig_client_credentials.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1173772
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AuthType.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/XhrwrapperConfigContributor.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfig.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContext.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Request.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BasicAuthenticationHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BearerTokenHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/ClientCredentialsGrantTypeHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeAuthorizationResponseHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeGrantTypeHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/OAuth2HandlerModule.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/StandardAuthenticationHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/TokenAuthorizationResponseHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheException.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionException.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceException.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCache.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypter.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModule.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/BasicOAuth2Message.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/OAuth2MessageModule.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/AuthTypeTest.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultInvalidationServiceTest.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriteModuleTest.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/server/pom.xml 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1173772
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java 1173772
Diff: https://reviews.apache.org/r/792/diff
Testing
-------
built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
Thanks,
li
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/#review784
-----------------------------------------------------------
Ship it!
Some nit comments: I still see some formatting issue, pleas use 2 spaces instead of tabs and limit to 120 chars per line.
Other than that LGTM.
- Henry
On 2011-06-06 14:45:37, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/792/
> -----------------------------------------------------------
>
> (Updated 2011-06-06 14:45:37)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
>
> As discussed, default AuthorityProvider would implement following logic with a Provider pattern
>
> 1. shindig.host & shindig.port defined in web.xml or system property
> 2. host/port from HttpServletRequest
> 3. Jetty host/port
>
> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686
>
> Diff: https://reviews.apache.org/r/792/diff
>
>
> Testing
> -------
>
> built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
-----------------------------------------------------------
(Updated 2011-06-06 14:45:37.546647)
Review request for shindig.
Changes
-------
Updated with Henry's comments. thanks.
Summary
-------
This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
As discussed, default AuthorityProvider would implement following logic with a Provider pattern
1. shindig.host & shindig.port defined in web.xml or system property
2. host/port from HttpServletRequest
3. Jetty host/port
link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686
Diff: https://reviews.apache.org/r/792/diff
Testing
-------
built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
Thanks,
li
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Li Xu <li...@us.ibm.com>.
Paul/Henry, thanks for helping out!
li
|------------>
| From: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Henry Saputra <he...@gmail.com> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|dev@shindig.apache.org |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|06/08/2011 05:03 PM |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Re: Review Request: Create default AuthorityProvider to support host/port |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
Oh cool, thanks Paul. I will let you finish it then.
- Henry
On Wed, Jun 8, 2011 at 1:53 PM, Paul Lindner <li...@inuus.com> wrote:
> actually I started on this.. Was in the process of cleaning for style...
>
>
> On Wed, Jun 8, 2011 at 1:47 PM, Henry Saputra
<he...@gmail.com>wrote:
>
>> Sure, I will commit this in the afternoon if no objection.
>>
>> - Henry
>>
>> On Wed, Jun 8, 2011 at 12:40 PM, John Hjelmstad <jo...@gmail.com>
>> wrote:
>>
>> > @Henry or @Paul, can you patch and commit this? LGTM but I'm swamped @
>> the
>> > moment :\
>> >
>> >
>> > On Wed, Jun 8, 2011 at 10:06 AM, Li Xu <li...@us.ibm.com> wrote:
>> >
>> >> Hello, John/Stanton/Henry
>> >> That patch has been posted for a while...would you please help moving
it
>> >> forward? thanks!
>> >> li
>> >>
>> >> [image: Inactive hide details for "li xu" ---06/03/2011 06:11:22
>> >> PM--------------------------------------------------------------
>> This]"li
>> >> xu" ---06/03/2011 06:11:22
>> >> PM-------------------------------------------------------------- This
is
>> an
>> >> automatically generated e-mai
>> >>
>> >>
>> >> From:
>> >> "li xu" <le...@gmail.com>
>> >> To:
>> >> johnfargo@gmail.com, "li xu" <le...@gmail.com>, Stanton
>> >> Sievers/Westford/IBM@Lotus, "shindig" <de...@shindig.apache.org>
>> >> Date:
>> >> 06/03/2011 06:11 PM
>> >> Subject:
>> >> Re: Review Request: Create default AuthorityProvider to support
>> host/port
>> >> ------------------------------
>> >>
>> >>
>> >>
>> >>
>> >> -----------------------------------------------------------
>> >>
>> >> This is an automatically generated e-mail. To reply, visit:
>> >> https://reviews.apache.org/r/792/
>> >>
>> >> -----------------------------------------------------------
>> >>
>> >> (Updated 2011-06-03 21:37:58.289676)
>> >>
>> >>
>> >> Review request for shindig.
>> >>
>> >>
>> >>
>> >> Changes
>> >> -------
>> >>
>> >> A new patch with comments addressed. thanks.
>> >>
>> >>
>> >> Summary
>> >> -------
>> >>
>> >>
>> >> This is a follow up for Issue 1534:
>> >> https://issues.apache.org/jira/browse/SHINDIG-1534
>> >>
>> >>
>> >> As discussed, default AuthorityProvider would implement following
logic
>> >> with a Provider pattern
>> >>
>> >> 1. shindig.host & shindig.port defined in web.xml or system property
>> >> 2. host/port from HttpServletRequest
>> >> 3. Jetty host/port
>> >>
>> >> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>> >>
>> >>
>> >>
>> >> Diffs (updated)
>> >> -----
>> >>
>> >>
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js1127686
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java1127686
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.javaPRE-CREATION
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.javaPRE-CREATION
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.javaPRE-CREATION
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java1127686
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.javaPRE-CREATION
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java1127686
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java1127686
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java1127686
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java1127686
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java1127686
>> >>
>> >>
>> >>
>>
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml1127686
>> >>
>> >>
>> >> Diff: https://reviews.apache.org/r/792/diff
>> >>
>> >>
>> >>
>> >> Testing
>> >> -------
>> >>
>> >> built, passed unit tests. tested with
>> >> /samplecontainer/examples/commoncontainer/index.html
>> >>
>> >>
>> >> Thanks,
>> >>
>> >> li
>> >>
>> >>
>> >>
>> >>
>> >
>>
>
>
>
> --
> Paul Lindner -- lindner@inuus.com -- linkedin.com/in/plindner
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Henry Saputra <he...@gmail.com>.
Oh cool, thanks Paul. I will let you finish it then.
- Henry
On Wed, Jun 8, 2011 at 1:53 PM, Paul Lindner <li...@inuus.com> wrote:
> actually I started on this.. Was in the process of cleaning for style...
>
>
> On Wed, Jun 8, 2011 at 1:47 PM, Henry Saputra <he...@gmail.com>wrote:
>
>> Sure, I will commit this in the afternoon if no objection.
>>
>> - Henry
>>
>> On Wed, Jun 8, 2011 at 12:40 PM, John Hjelmstad <jo...@gmail.com>
>> wrote:
>>
>> > @Henry or @Paul, can you patch and commit this? LGTM but I'm swamped @
>> the
>> > moment :\
>> >
>> >
>> > On Wed, Jun 8, 2011 at 10:06 AM, Li Xu <li...@us.ibm.com> wrote:
>> >
>> >> Hello, John/Stanton/Henry
>> >> That patch has been posted for a while...would you please help moving it
>> >> forward? thanks!
>> >> li
>> >>
>> >> [image: Inactive hide details for "li xu" ---06/03/2011 06:11:22
>> >> PM--------------------------------------------------------------
>> This]"li
>> >> xu" ---06/03/2011 06:11:22
>> >> PM-------------------------------------------------------------- This is
>> an
>> >> automatically generated e-mai
>> >>
>> >>
>> >> From:
>> >> "li xu" <le...@gmail.com>
>> >> To:
>> >> johnfargo@gmail.com, "li xu" <le...@gmail.com>, Stanton
>> >> Sievers/Westford/IBM@Lotus, "shindig" <de...@shindig.apache.org>
>> >> Date:
>> >> 06/03/2011 06:11 PM
>> >> Subject:
>> >> Re: Review Request: Create default AuthorityProvider to support
>> host/port
>> >> ------------------------------
>> >>
>> >>
>> >>
>> >>
>> >> -----------------------------------------------------------
>> >>
>> >> This is an automatically generated e-mail. To reply, visit:
>> >> https://reviews.apache.org/r/792/
>> >>
>> >> -----------------------------------------------------------
>> >>
>> >> (Updated 2011-06-03 21:37:58.289676)
>> >>
>> >>
>> >> Review request for shindig.
>> >>
>> >>
>> >>
>> >> Changes
>> >> -------
>> >>
>> >> A new patch with comments addressed. thanks.
>> >>
>> >>
>> >> Summary
>> >> -------
>> >>
>> >>
>> >> This is a follow up for Issue 1534:
>> >> https://issues.apache.org/jira/browse/SHINDIG-1534
>> >>
>> >>
>> >> As discussed, default AuthorityProvider would implement following logic
>> >> with a Provider pattern
>> >>
>> >> 1. shindig.host & shindig.port defined in web.xml or system property
>> >> 2. host/port from HttpServletRequest
>> >> 3. Jetty host/port
>> >>
>> >> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>> >>
>> >>
>> >>
>> >> Diffs (updated)
>> >> -----
>> >>
>> >> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js1127686
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java1127686
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.javaPRE-CREATION
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.javaPRE-CREATION
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.javaPRE-CREATION
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java1127686
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.javaPRE-CREATION
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java1127686
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java1127686
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java1127686
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java1127686
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java1127686
>> >>
>> >>
>> >>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml1127686
>> >>
>> >>
>> >> Diff: https://reviews.apache.org/r/792/diff
>> >>
>> >>
>> >>
>> >> Testing
>> >> -------
>> >>
>> >> built, passed unit tests. tested with
>> >> /samplecontainer/examples/commoncontainer/index.html
>> >>
>> >>
>> >> Thanks,
>> >>
>> >> li
>> >>
>> >>
>> >>
>> >>
>> >
>>
>
>
>
> --
> Paul Lindner -- lindner@inuus.com -- linkedin.com/in/plindner
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Paul Lindner <li...@inuus.com>.
actually I started on this.. Was in the process of cleaning for style...
On Wed, Jun 8, 2011 at 1:47 PM, Henry Saputra <he...@gmail.com>wrote:
> Sure, I will commit this in the afternoon if no objection.
>
> - Henry
>
> On Wed, Jun 8, 2011 at 12:40 PM, John Hjelmstad <jo...@gmail.com>
> wrote:
>
> > @Henry or @Paul, can you patch and commit this? LGTM but I'm swamped @
> the
> > moment :\
> >
> >
> > On Wed, Jun 8, 2011 at 10:06 AM, Li Xu <li...@us.ibm.com> wrote:
> >
> >> Hello, John/Stanton/Henry
> >> That patch has been posted for a while...would you please help moving it
> >> forward? thanks!
> >> li
> >>
> >> [image: Inactive hide details for "li xu" ---06/03/2011 06:11:22
> >> PM--------------------------------------------------------------
> This]"li
> >> xu" ---06/03/2011 06:11:22
> >> PM-------------------------------------------------------------- This is
> an
> >> automatically generated e-mai
> >>
> >>
> >> From:
> >> "li xu" <le...@gmail.com>
> >> To:
> >> johnfargo@gmail.com, "li xu" <le...@gmail.com>, Stanton
> >> Sievers/Westford/IBM@Lotus, "shindig" <de...@shindig.apache.org>
> >> Date:
> >> 06/03/2011 06:11 PM
> >> Subject:
> >> Re: Review Request: Create default AuthorityProvider to support
> host/port
> >> ------------------------------
> >>
> >>
> >>
> >>
> >> -----------------------------------------------------------
> >>
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/792/
> >>
> >> -----------------------------------------------------------
> >>
> >> (Updated 2011-06-03 21:37:58.289676)
> >>
> >>
> >> Review request for shindig.
> >>
> >>
> >>
> >> Changes
> >> -------
> >>
> >> A new patch with comments addressed. thanks.
> >>
> >>
> >> Summary
> >> -------
> >>
> >>
> >> This is a follow up for Issue 1534:
> >> https://issues.apache.org/jira/browse/SHINDIG-1534
> >>
> >>
> >> As discussed, default AuthorityProvider would implement following logic
> >> with a Provider pattern
> >>
> >> 1. shindig.host & shindig.port defined in web.xml or system property
> >> 2. host/port from HttpServletRequest
> >> 3. Jetty host/port
> >>
> >> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
> >>
> >>
> >>
> >> Diffs (updated)
> >> -----
> >>
> >> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js1127686
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java1127686
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.javaPRE-CREATION
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.javaPRE-CREATION
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.javaPRE-CREATION
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java1127686
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.javaPRE-CREATION
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java1127686
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java1127686
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java1127686
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java1127686
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java1127686
> >>
> >>
> >>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml1127686
> >>
> >>
> >> Diff: https://reviews.apache.org/r/792/diff
> >>
> >>
> >>
> >> Testing
> >> -------
> >>
> >> built, passed unit tests. tested with
> >> /samplecontainer/examples/commoncontainer/index.html
> >>
> >>
> >> Thanks,
> >>
> >> li
> >>
> >>
> >>
> >>
> >
>
--
Paul Lindner -- lindner@inuus.com -- linkedin.com/in/plindner
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Henry Saputra <he...@gmail.com>.
Sure, I will commit this in the afternoon if no objection.
- Henry
On Wed, Jun 8, 2011 at 12:40 PM, John Hjelmstad <jo...@gmail.com> wrote:
> @Henry or @Paul, can you patch and commit this? LGTM but I'm swamped @ the
> moment :\
>
>
> On Wed, Jun 8, 2011 at 10:06 AM, Li Xu <li...@us.ibm.com> wrote:
>
>> Hello, John/Stanton/Henry
>> That patch has been posted for a while...would you please help moving it
>> forward? thanks!
>> li
>>
>> [image: Inactive hide details for "li xu" ---06/03/2011 06:11:22
>> PM-------------------------------------------------------------- This]"li
>> xu" ---06/03/2011 06:11:22
>> PM-------------------------------------------------------------- This is an
>> automatically generated e-mai
>>
>>
>> From:
>> "li xu" <le...@gmail.com>
>> To:
>> johnfargo@gmail.com, "li xu" <le...@gmail.com>, Stanton
>> Sievers/Westford/IBM@Lotus, "shindig" <de...@shindig.apache.org>
>> Date:
>> 06/03/2011 06:11 PM
>> Subject:
>> Re: Review Request: Create default AuthorityProvider to support host/port
>> ------------------------------
>>
>>
>>
>>
>> -----------------------------------------------------------
>>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/792/
>>
>> -----------------------------------------------------------
>>
>> (Updated 2011-06-03 21:37:58.289676)
>>
>>
>> Review request for shindig.
>>
>>
>>
>> Changes
>> -------
>>
>> A new patch with comments addressed. thanks.
>>
>>
>> Summary
>> -------
>>
>>
>> This is a follow up for Issue 1534:
>> https://issues.apache.org/jira/browse/SHINDIG-1534
>>
>>
>> As discussed, default AuthorityProvider would implement following logic
>> with a Provider pattern
>>
>> 1. shindig.host & shindig.port defined in web.xml or system property
>> 2. host/port from HttpServletRequest
>> 3. Jetty host/port
>>
>> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>>
>>
>>
>> Diffs (updated)
>> -----
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686
>>
>>
>> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686
>>
>>
>> Diff: https://reviews.apache.org/r/792/diff
>>
>>
>>
>> Testing
>> -------
>>
>> built, passed unit tests. tested with
>> /samplecontainer/examples/commoncontainer/index.html
>>
>>
>> Thanks,
>>
>> li
>>
>>
>>
>>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by John Hjelmstad <jo...@gmail.com>.
@Henry or @Paul, can you patch and commit this? LGTM but I'm swamped @ the
moment :\
On Wed, Jun 8, 2011 at 10:06 AM, Li Xu <li...@us.ibm.com> wrote:
> Hello, John/Stanton/Henry
> That patch has been posted for a while...would you please help moving it
> forward? thanks!
> li
>
> [image: Inactive hide details for "li xu" ---06/03/2011 06:11:22
> PM-------------------------------------------------------------- This]"li
> xu" ---06/03/2011 06:11:22
> PM-------------------------------------------------------------- This is an
> automatically generated e-mai
>
>
> From:
> "li xu" <le...@gmail.com>
> To:
> johnfargo@gmail.com, "li xu" <le...@gmail.com>, Stanton
> Sievers/Westford/IBM@Lotus, "shindig" <de...@shindig.apache.org>
> Date:
> 06/03/2011 06:11 PM
> Subject:
> Re: Review Request: Create default AuthorityProvider to support host/port
> ------------------------------
>
>
>
>
> -----------------------------------------------------------
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/792/
>
> -----------------------------------------------------------
>
> (Updated 2011-06-03 21:37:58.289676)
>
>
> Review request for shindig.
>
>
>
> Changes
> -------
>
> A new patch with comments addressed. thanks.
>
>
> Summary
> -------
>
>
> This is a follow up for Issue 1534:
> https://issues.apache.org/jira/browse/SHINDIG-1534
>
>
> As discussed, default AuthorityProvider would implement following logic
> with a Provider pattern
>
> 1. shindig.host & shindig.port defined in web.xml or system property
> 2. host/port from HttpServletRequest
> 3. Jetty host/port
>
> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>
>
>
> Diffs (updated)
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686
>
>
> Diff: https://reviews.apache.org/r/792/diff
>
>
>
> Testing
> -------
>
> built, passed unit tests. tested with
> /samplecontainer/examples/commoncontainer/index.html
>
>
> Thanks,
>
> li
>
>
>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by Li Xu <li...@us.ibm.com>.
Hello, John/Stanton/Henry
That patch has been posted for a while...would you please help moving it
forward? thanks!
li
|------------>
| From: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|"li xu" <le...@gmail.com> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|johnfargo@gmail.com, "li xu" <le...@gmail.com>, Stanton Sievers/Westford/IBM@Lotus, "shindig" <de...@shindig.apache.org> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|06/03/2011 06:11 PM |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Re: Review Request: Create default AuthorityProvider to support host/port |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
-----------------------------------------------------------
(Updated 2011-06-03 21:37:58.289676)
Review request for shindig.
Changes
-------
A new patch with comments addressed. thanks.
Summary
-------
This is a follow up for Issue 1534:
https://issues.apache.org/jira/browse/SHINDIG-1534
As discussed, default AuthorityProvider would implement following logic
with a Provider pattern
1. shindig.host & shindig.port defined in web.xml or system property
2. host/port from HttpServletRequest
3. Jetty host/port
link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java
1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java
1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java
1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java
1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml
1127686
Diff: https://reviews.apache.org/r/792/diff
Testing
-------
built, passed unit tests. tested
with /samplecontainer/examples/commoncontainer/index.html
Thanks,
li
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
-----------------------------------------------------------
(Updated 2011-06-03 21:37:58.289676)
Review request for shindig.
Changes
-------
A new patch with comments addressed. thanks.
Summary
-------
This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
As discussed, default AuthorityProvider would implement following logic with a Provider pattern
1. shindig.host & shindig.port defined in web.xml or system property
2. host/port from HttpServletRequest
3. Jetty host/port
link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686
Diff: https://reviews.apache.org/r/792/diff
Testing
-------
built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
Thanks,
li
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by li xu <le...@gmail.com>.
> On 2011-06-03 18:45:20, johnfargo wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java, line 82
> > <https://reviews.apache.org/r/792/diff/2/?file=20132#file20132line82>
> >
> > Why remove the Jetty properties? Not a big deal for me, but curious anyway.
it's moved to BasicAuthority. I have to do this since fallback is done there and host/port from request takes priority first.
> On 2011-06-03 18:45:20, johnfargo wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java, line 17
> > <https://reviews.apache.org/r/792/diff/2/?file=20133#file20133line17>
> >
> > Nit: could call this "getOrigin()" since that term is typically used for schema://authority
done.
> On 2011-06-03 18:45:20, johnfargo wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/AuthorityProvider.java, line 44
> > <https://reviews.apache.org/r/792/diff/2/?file=20134#file20134line44>
> >
> > Why not rename this BasicAuthorityProvider, and just @Inject a BasicAuthority into it? Then, BasicAuthority itself would have @Inject on its ctor w/ the shindig.host and shindig.port values.
> >
> > Others could still use the class w/o the annotations.
> >
done.
> On 2011-06-03 18:45:20, johnfargo wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, line 18
> > <https://reviews.apache.org/r/792/diff/2/?file=20135#file20135line18>
> >
> > nits: prefer 2-space indent thru this file
done.
> On 2011-06-03 18:45:20, johnfargo wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, line 45
> > <https://reviews.apache.org/r/792/diff/2/?file=20135#file20135line45>
> >
> > I'd recommend pulling jetty.port and jetty.host strings into public static final Strings at the top of the class.
done.
> On 2011-06-03 18:45:20, johnfargo wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java, line 32
> > <https://reviews.apache.org/r/792/diff/2/?file=20136#file20136line32>
> >
> > For better consistency, I'd put all these Strings into public static finals as well so that their value is defined only once throughout the class.
done.
> On 2011-06-03 18:45:20, johnfargo wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java, line 33
> > <https://reviews.apache.org/r/792/diff/2/?file=20136#file20136line33>
> >
> > getServerPort().toString()
int.toString() will not work, used ""+<int> to convert int to String.
> On 2011-06-03 18:45:20, johnfargo wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, line 39
> > <https://reviews.apache.org/r/792/diff/2/?file=20135#file20135line39>
> >
> > Interesting, so you're just using the jetty values as a fallback in the default impl? Suppose that's fine.
yes. system properties first, values in request 2nd, fallback to jetty if neither is available. test cases works with jetty host/port.
- li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/#review756
-----------------------------------------------------------
On 2011-06-03 21:37:58, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/792/
> -----------------------------------------------------------
>
> (Updated 2011-06-03 21:37:58)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
>
> As discussed, default AuthorityProvider would implement following logic with a Provider pattern
>
> 1. shindig.host & shindig.port defined in web.xml or system property
> 2. host/port from HttpServletRequest
> 3. Jetty host/port
>
> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1127686
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1127686
>
> Diff: https://reviews.apache.org/r/792/diff
>
>
> Testing
> -------
>
> built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by jo...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/#review756
-----------------------------------------------------------
Hi Li -- thanks for doing this. A few structuring comments before I go ahead and patch/commit it.
Best,
John
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
<https://reviews.apache.org/r/792/#comment1582>
Why remove the Jetty properties? Not a big deal for me, but curious anyway.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java
<https://reviews.apache.org/r/792/#comment1583>
Nit: could call this "getOrigin()" since that term is typically used for schema://authority
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/AuthorityProvider.java
<https://reviews.apache.org/r/792/#comment1587>
Why not rename this BasicAuthorityProvider, and just @Inject a BasicAuthority into it? Then, BasicAuthority itself would have @Inject on its ctor w/ the shindig.host and shindig.port values.
Others could still use the class w/o the annotations.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java
<https://reviews.apache.org/r/792/#comment1584>
nits: prefer 2-space indent thru this file
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java
<https://reviews.apache.org/r/792/#comment1585>
Interesting, so you're just using the jetty values as a fallback in the default impl? Suppose that's fine.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java
<https://reviews.apache.org/r/792/#comment1586>
I'd recommend pulling jetty.port and jetty.host strings into public static final Strings at the top of the class.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java
<https://reviews.apache.org/r/792/#comment1589>
For better consistency, I'd put all these Strings into public static finals as well so that their value is defined only once throughout the class.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java
<https://reviews.apache.org/r/792/#comment1588>
getServerPort().toString()
- johnfargo
On 2011-06-01 20:23:51, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/792/
> -----------------------------------------------------------
>
> (Updated 2011-06-01 20:23:51)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
>
> As discussed, default AuthorityProvider would implement following logic with a Provider pattern
>
> 1. shindig.host & shindig.port defined in web.xml or system property
> 2. host/port from HttpServletRequest
> 3. Jetty host/port
>
> link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1125049
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1125049
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/AuthorityProvider.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1124991
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/AuthorityProviderTest.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1124991
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1126359
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1124991
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1124991
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1126359
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1124991
>
> Diff: https://reviews.apache.org/r/792/diff
>
>
> Testing
> -------
>
> built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: Create default AuthorityProvider to support host/port
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/792/
-----------------------------------------------------------
(Updated 2011-06-01 20:23:51.068414)
Review request for shindig.
Summary
-------
This is a follow up for Issue 1534: https://issues.apache.org/jira/browse/SHINDIG-1534
As discussed, default AuthorityProvider would implement following logic with a Provider pattern
1. shindig.host & shindig.port defined in web.xml or system property
2. host/port from HttpServletRequest
3. Jetty host/port
link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1125049
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java 1125049
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/AuthorityProvider.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java 1124991
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/AuthorityProviderTest.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1124991
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java 1126359
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1124991
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java 1124991
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java 1126359
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml 1124991
Diff: https://reviews.apache.org/r/792/diff
Testing (updated)
-------
built, passed unit tests. tested with /samplecontainer/examples/commoncontainer/index.html
Thanks,
li