You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/05/09 12:37:55 UTC

[GitHub] [libcloud] dzaytsev91 opened a new pull request, #1686: added new connection type

dzaytsev91 opened a new pull request, #1686:
URL: https://github.com/apache/libcloud/pull/1686

   ## Changes Title (replace this with a logical title for your changes)
   
   ### Description
   
   Added new connection type which support `user_id`, `password` and `key` arguments
   
   ### Status
   
   ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [x] Documentation
   - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami closed pull request #1686: added new connection type

Posted by GitBox <gi...@apache.org>.
Kami closed pull request #1686: added new connection type
URL: https://github.com/apache/libcloud/pull/1686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1686: added new connection type

Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1686:
URL: https://github.com/apache/libcloud/pull/1686#issuecomment-1122932343

   Thanks for the contribution.
   
   Overall the change looks good to me, but I would be good to see the following:
   
   1. I would like to understanding the reasoning / context / use case behind this change
   2. Some tests would be good
   3. If applicable, some documentation would also be good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1686: added new connection type

Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1686:
URL: https://github.com/apache/libcloud/pull/1686#issuecomment-1345294007

   Closing this PR since it hasn't been updated for a while. If it's still relevant, please re-open it / open a new PR. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org