[jira] [Commented] (OFBIZ-5619) Minilang call-service always use transaction

["Jacopo Cappellato (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974030#comment-13974030 ] 

Jacopo Cappellato commented on OFBIZ-5619:
------------------------------------------

Hi Simone,

I have reviewed this ticket, your patch and also quickly the OFBiz code and I don't think it is a real issue.
In fact the code in runSync sets the proper field in the cloned model:
{code}cloned.requireNewTransaction = requireNewTransaction;{code}
Could you please double check your tests?
Thanks

> Minilang call-service always use transaction
> --------------------------------------------
>
>                 Key: OFBIZ-5619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Simone Viani
>            Assignee: Jacopo Cappellato
>         Attachments: OFBIZ-5619.patch
>
>
> Minilang call-service, and some of the runSync, always use transaction, even if the called service is defined to not use it.
> {code:title=GenericDispatcherFactory.java}
> public Map<String, Object> runSync(String serviceName, Map<String, ? extends Object> context, int transactionTimeout, boolean requireNewTransaction) throws ServiceAuthException, ServiceValidationException, GenericServiceException {
>   // ...
>   ModelService cloned = new ModelService(service);
>   // ...
> }
> {code}
> {code:title=ModelService.java}
> public boolean useTransaction;
> // ...
> public ModelService(ModelService model) {
>   // ...
>   this.useTransaction = model.useTransaction || true;
>   // ...
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)