(superset) branch master updated: fix(a11y): associate Description label with TagModal input (#42034)

[el...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

eschutho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new da518d7a107 fix(a11y): associate Description label with TagModal input (#42034)
da518d7a107 is described below

commit da518d7a1071cce8e8169155c3e29efceb78c1f7
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Wed Jul 15 15:03:40 2026 -0700

    fix(a11y): associate Description label with TagModal input (#42034)
---
 superset-frontend/src/features/tags/TagModal.test.tsx | 5 +++++
 superset-frontend/src/features/tags/TagModal.tsx      | 5 ++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/src/features/tags/TagModal.test.tsx b/superset-frontend/src/features/tags/TagModal.test.tsx
index 0fce2de2e83..ee38ff43ecb 100644
--- a/superset-frontend/src/features/tags/TagModal.test.tsx
+++ b/superset-frontend/src/features/tags/TagModal.test.tsx
@@ -45,6 +45,11 @@ test('renders correctly in create mode', () => {
   expect(getByText('Create Tag')).toBeInTheDocument();
 });
 
+test('description input has an accessible name', async () => {
+  render(<TagModal {...mockedProps} />);
+  expect(await screen.findByLabelText('Tag description')).toBeInTheDocument();
+});
+
 test('renders correctly in edit mode', () => {
   fetchMock.get(fetchEditFetchObjects, [[]]);
   const editTag: Tag = {
diff --git a/superset-frontend/src/features/tags/TagModal.tsx b/superset-frontend/src/features/tags/TagModal.tsx
index aea360617de..1d80276d453 100644
--- a/superset-frontend/src/features/tags/TagModal.tsx
+++ b/superset-frontend/src/features/tags/TagModal.tsx
@@ -312,8 +312,11 @@ const TagModal: FC<TagModalProps> = ({
         </Flex>
 
         <Flex vertical gap={theme.sizeUnit}>
-          <FormLabel>{t('Description')}</FormLabel>
+          <FormLabel htmlFor="tag-description">
+            {t('Tag description')}
+          </FormLabel>
           <Input
+            id="tag-description"
             className="tag-input"
             onChange={handleDescriptionChange}
             placeholder={t('Add description of your tag')}