You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by tw...@apache.org on 2016/07/08 12:39:58 UTC

[40/50] [abbrv] tinkerpop git commit: Void and void can not use FieldSerializers. However, note that Void and void are in DefaultSerializers and thus, don't need to be registered by GryoRegistrator. Commented them out and added a note if for some reason

Void and void can not use FieldSerializers. However, note that Void and void are in DefaultSerializers and thus, don't need to be registered by GryoRegistrator. Commented them out and added a note if for some reason Void and void require serializaion registration. However, integration tests pass now and Void/void were not a problem. CTR. cc/ @dalaro


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/f9706a38
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/f9706a38
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/f9706a38

Branch: refs/heads/TINKERPOP-1254
Commit: f9706a38fbe546c0a7e5b038a6b99303d21aec01
Parents: ca8a4f9
Author: Marko A. Rodriguez <ok...@gmail.com>
Authored: Wed Jul 6 08:27:00 2016 -0600
Committer: Marko A. Rodriguez <ok...@gmail.com>
Committed: Wed Jul 6 08:27:00 2016 -0600

----------------------------------------------------------------------
 .../gremlin/spark/structure/io/gryo/GryoRegistrator.java       | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/f9706a38/spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/structure/io/gryo/GryoRegistrator.java
----------------------------------------------------------------------
diff --git a/spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/structure/io/gryo/GryoRegistrator.java b/spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/structure/io/gryo/GryoRegistrator.java
index 9e5d4e1..ffd731a 100644
--- a/spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/structure/io/gryo/GryoRegistrator.java
+++ b/spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/structure/io/gryo/GryoRegistrator.java
@@ -218,8 +218,10 @@ public class GryoRegistrator implements KryoRegistrator {
         }
         //
         m.put(CompactBuffer[].class, null);
-        m.put(void.class, null);
-        m.put(Void.class, null);
+        // TODO: VoidSerializer is a default serializer and thus, may not be needed (if it is, you can't use FieldSerializer)
+        // TODO: We will have to copy/paste the shaded DefaultSerializer.VoidSerializer into an unshaded form.
+        //m.put(void.class, null);
+        //m.put(Void.class, null);
         return m;
     }