You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/10/10 22:31:14 UTC

[kudu-CR](branch-1.5.x) KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8252


Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8
......................................................................

KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

This particular problem surfaced in an OpenJDK bug report [1] (more info
also available at [2]). To address it we can either:
- Set javac's "boot classpath" to JDK7's rt.jar when building with JDK8.
- Ensure that the ConcurrentHashMap is used as a Map when calling keySet().

Given that there's just one instance of this, the latter is way easier than
the former.

1. https://bugs.openjdk.java.net/browse/JDK-8151366
2. https://gist.github.com/AlainODea/1375759b8720a3f9f094

Change-Id: I27f3db32eaba759f2781a211673fe0aaabd3f83d
Reviewed-on: http://gerrit.cloudera.org:8080/8249
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Todd Lipcon <to...@apache.org>
(cherry picked from commit afdeb9ea218216631ae325b3205c23adb1061037)
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Statistics.java
1 file changed, 12 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/8252/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27f3db32eaba759f2781a211673fe0aaabd3f83d
Gerrit-Change-Number: 8252
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>

[kudu-CR](branch-1.5.x) KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8252 )

Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8
......................................................................

KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

This particular problem surfaced in an OpenJDK bug report [1] (more info
also available at [2]). To address it we can either:
- Set javac's "boot classpath" to JDK7's rt.jar when building with JDK8.
- Ensure that the ConcurrentHashMap is used as a Map when calling keySet().

Given that there's just one instance of this, the latter is way easier than
the former.

1. https://bugs.openjdk.java.net/browse/JDK-8151366
2. https://gist.github.com/AlainODea/1375759b8720a3f9f094

Change-Id: I27f3db32eaba759f2781a211673fe0aaabd3f83d
Reviewed-on: http://gerrit.cloudera.org:8080/8249
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Todd Lipcon <to...@apache.org>
(cherry picked from commit afdeb9ea218216631ae325b3205c23adb1061037)
Reviewed-on: http://gerrit.cloudera.org:8080/8252
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Statistics.java
1 file changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/8252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I27f3db32eaba759f2781a211673fe0aaabd3f83d
Gerrit-Change-Number: 8252
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.5.x) KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8252 )

Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I27f3db32eaba759f2781a211673fe0aaabd3f83d
Gerrit-Change-Number: 8252
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Oct 2017 23:42:52 +0000
Gerrit-HasComments: No