[GitHub] [ozone] umamaheswararao commented on a change in pull request #2401: EC: Make ECReplicationConfig stored as bucket level attributes.

[GitBox <gi...@apache.org>]

umamaheswararao commented on a change in pull request #2401:
URL: https://github.com/apache/ozone/pull/2401#discussion_r672841257



##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -519,6 +519,7 @@ message BucketInfo {
     optional int64 quotaInBytes = 15 [default = -2];
     optional int64 quotaInNamespace = 16 [default = -2];
     optional uint64 usedNamespace = 17;
+    optional hadoop.hdds.ECReplicationConfig ecReplicationConfig = 18;

Review comment:
       What do you mean by embedded structure?
   you mean to create another proto structure containing ecReplicationConfig/ratisReplicationConfig/standaloneReplicationConfig ? Isn't this force to create proto structures for ratisReplicationConfig/standaloneReplicationConfig as well? IIRC, Currently we have proto structures only for EcReplicationConfig. Not sure this embedded structure confuses ( All other structures have ECREplicationCOnfig, type and  factor. But bucket will have some embedded structure). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org