You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/14 01:14:46 UTC
[GitHub] [arrow-rs] Jimexist opened a new pull request, #3104: (WIP) test with thrift 0.17 and fix issues
Jimexist opened a new pull request, #3104:
URL: https://github.com/apache/arrow-rs/pull/3104
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist merged pull request #3104: Upgrade to thrift 0.17 and fix issues
Posted by GitBox <gi...@apache.org>.
Jimexist merged PR #3104:
URL: https://github.com/apache/arrow-rs/pull/3104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on a diff in pull request #3104: (WIP) test with thrift 0.17 and fix issues
Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #3104:
URL: https://github.com/apache/arrow-rs/pull/3104#discussion_r1021004903
##########
parquet/Cargo.toml:
##########
@@ -41,7 +41,7 @@ arrow-ipc = { version = "27.0.0", path = "../arrow-ipc", default-features = fals
ahash = { version = "0.8", default-features = false, features = ["compile-time-rng"] }
bytes = { version = "1.1", default-features = false, features = ["std"] }
-thrift = { version = "0.16", default-features = false }
+thrift = { version = "0.17", package = "databend-thrift", default-features = false }
Review Comment:
will change back once verification is done. we are in the process of publishing this.
##########
parquet/Cargo.toml:
##########
@@ -41,7 +41,7 @@ arrow-ipc = { version = "27.0.0", path = "../arrow-ipc", default-features = fals
ahash = { version = "0.8", default-features = false, features = ["compile-time-rng"] }
bytes = { version = "1.1", default-features = false, features = ["std"] }
-thrift = { version = "0.16", default-features = false }
+thrift = { version = "0.17", package = "databend-thrift", default-features = false }
Review Comment:
will change back once verification is done. we (thrift committers) are in the process of publishing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3104: Upgrade to thrift 0.17 and fix issues
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3104:
URL: https://github.com/apache/arrow-rs/pull/3104#issuecomment-1313324162
Benchmark runs are scheduled for baseline = 430eb84d0d64b15e2f8b13dfa0f3bd014d3e50c9 and contender = 0900be27859974b8717185d65422c36d7e735b4e. 0900be27859974b8717185d65422c36d7e735b4e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/82a5512593364d74abed40e8884b7ac1...91373f0a1ed34ef88efc76244784c220/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c7aa266c5a884fe289b1feede54a1f06...7eb1e92711a44560bb9d2f68901ef77d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c682fe754cf04082a0423ff37ffa6234...724b3138f6eb4f5da2b5c07c21a45038/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/498ccbbe7a2540649a48dc915b92ea63...8c7d7b553f2048d2985679aac93b1f19/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3104: Upgrade to thrift 0.17 and fix issues
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3104:
URL: https://github.com/apache/arrow-rs/pull/3104#issuecomment-1313088329
> cargo doc failed, not sure we should just ignore the format file which is autogenerated
My vote would be to manually patch up the doc comments it is complaining about. That's what I did before... Might even be scriptable...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on pull request #3104: Upgrade to thrift 0.17 and fix issues
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #3104:
URL: https://github.com/apache/arrow-rs/pull/3104#issuecomment-1313057831
`cargo doc` failed, not sure we should just ignore the format file which is autogenerated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org