You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jesse Long (JIRA)" <ji...@apache.org> on 2012/06/07 23:36:22 UTC
[jira] [Created] (WICKET-4596) DataTable toolbars do not handle
dynamically changing columns in the table
Jesse Long created WICKET-4596:
----------------------------------
Summary: DataTable toolbars do not handle dynamically changing columns in the table
Key: WICKET-4596
URL: https://issues.apache.org/jira/browse/WICKET-4596
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 6.0.0-beta2
Reporter: Jesse Long
Priority: Minor
All the packaged toolbars for the DataTables fail to handle dynamically changing column in the table.
HeadersToolbar - is new columns are added, they do not have headers. If columns are removed, the headers are not removed.
NoRecordsToolbar - colspan is static to the number of columns when the table was created. If more columns are added, or if columns are removed, then the incorrect colspan is used.
NavigationToolbar - incorrect static colspan, like NoRecordsToolbar.
FilterToolbar - same problem as HeadersToolbar, just s/header/filter/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4596) DataTable toolbars do not handle
dynamically changing columns in the table
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295234#comment-13295234 ]
Sven Meier commented on WICKET-4596:
------------------------------------
Tested FilterToolbar with Phonebook application, works fine.
> DataTable toolbars do not handle dynamically changing columns in the table
> --------------------------------------------------------------------------
>
> Key: WICKET-4596
> URL: https://issues.apache.org/jira/browse/WICKET-4596
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0-beta2
> Reporter: Jesse Long
> Priority: Minor
> Fix For: 6.0.0-RC1
>
> Attachments: fix-WICKET-4596.patch, myproject2.zip
>
>
> All the packaged toolbars for the DataTables fail to handle dynamically changing column in the table.
> HeadersToolbar - is new columns are added, they do not have headers. If columns are removed, the headers are not removed.
> NoRecordsToolbar - colspan is static to the number of columns when the table was created. If more columns are added, or if columns are removed, then the incorrect colspan is used.
> NavigationToolbar - incorrect static colspan, like NoRecordsToolbar.
> FilterToolbar - same problem as HeadersToolbar, just s/header/filter/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4596) DataTable toolbars do not handle
dynamically changing columns in the table
Posted by "Jesse Long (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Long updated WICKET-4596:
-------------------------------
Attachment: myproject2.zip
myproject2.zip - quickstart demoing the problem. You can see HeadersToolbar and NavigationToolar problems here. Same type of problems apply to FilterToolbar and NoRecordsToolbar respectively.
> DataTable toolbars do not handle dynamically changing columns in the table
> --------------------------------------------------------------------------
>
> Key: WICKET-4596
> URL: https://issues.apache.org/jira/browse/WICKET-4596
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0-beta2
> Reporter: Jesse Long
> Priority: Minor
> Attachments: myproject2.zip
>
>
> All the packaged toolbars for the DataTables fail to handle dynamically changing column in the table.
> HeadersToolbar - is new columns are added, they do not have headers. If columns are removed, the headers are not removed.
> NoRecordsToolbar - colspan is static to the number of columns when the table was created. If more columns are added, or if columns are removed, then the incorrect colspan is used.
> NavigationToolbar - incorrect static colspan, like NoRecordsToolbar.
> FilterToolbar - same problem as HeadersToolbar, just s/header/filter/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4596) DataTable toolbars do not handle
dynamically changing columns in the table
Posted by "Jesse Long (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291336#comment-13291336 ]
Jesse Long commented on WICKET-4596:
------------------------------------
My patch also removes AjaxNavigationToolbar.html which is not needed. NavigationToolbar.html does everything AjaxNavigationToolbar.html, slightly better.
> DataTable toolbars do not handle dynamically changing columns in the table
> --------------------------------------------------------------------------
>
> Key: WICKET-4596
> URL: https://issues.apache.org/jira/browse/WICKET-4596
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0-beta2
> Reporter: Jesse Long
> Priority: Minor
> Attachments: fix-WICKET-4596.patch, myproject2.zip
>
>
> All the packaged toolbars for the DataTables fail to handle dynamically changing column in the table.
> HeadersToolbar - is new columns are added, they do not have headers. If columns are removed, the headers are not removed.
> NoRecordsToolbar - colspan is static to the number of columns when the table was created. If more columns are added, or if columns are removed, then the incorrect colspan is used.
> NavigationToolbar - incorrect static colspan, like NoRecordsToolbar.
> FilterToolbar - same problem as HeadersToolbar, just s/header/filter/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4596) DataTable toolbars do not handle
dynamically changing columns in the table
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier resolved WICKET-4596.
--------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0-RC1
Assignee: Sven Meier
Applied with minor changes, thanks.
> DataTable toolbars do not handle dynamically changing columns in the table
> --------------------------------------------------------------------------
>
> Key: WICKET-4596
> URL: https://issues.apache.org/jira/browse/WICKET-4596
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0-beta2
> Reporter: Jesse Long
> Assignee: Sven Meier
> Priority: Minor
> Fix For: 6.0.0-RC1
>
> Attachments: fix-WICKET-4596.patch, myproject2.zip
>
>
> All the packaged toolbars for the DataTables fail to handle dynamically changing column in the table.
> HeadersToolbar - is new columns are added, they do not have headers. If columns are removed, the headers are not removed.
> NoRecordsToolbar - colspan is static to the number of columns when the table was created. If more columns are added, or if columns are removed, then the incorrect colspan is used.
> NavigationToolbar - incorrect static colspan, like NoRecordsToolbar.
> FilterToolbar - same problem as HeadersToolbar, just s/header/filter/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4596) DataTable toolbars do not handle
dynamically changing columns in the table
Posted by "Jesse Long (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Long updated WICKET-4596:
-------------------------------
Attachment: fix-WICKET-4596.patch
fix-WICKET-4596.patch - patch to fix.
HeadersToolbar and FilterToolbar: use RefreshingView for td/th instead of RepeatingView.
NoRecordsToolbar and NavigationToolbar: use IModel<String> for colspan value, instead of static string. IModel gets value from current number of columns.
Disclaimer: I have not tested FilterToolbar. Please check that FilterToolbar is correct.
> DataTable toolbars do not handle dynamically changing columns in the table
> --------------------------------------------------------------------------
>
> Key: WICKET-4596
> URL: https://issues.apache.org/jira/browse/WICKET-4596
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0-beta2
> Reporter: Jesse Long
> Priority: Minor
> Attachments: fix-WICKET-4596.patch, myproject2.zip
>
>
> All the packaged toolbars for the DataTables fail to handle dynamically changing column in the table.
> HeadersToolbar - is new columns are added, they do not have headers. If columns are removed, the headers are not removed.
> NoRecordsToolbar - colspan is static to the number of columns when the table was created. If more columns are added, or if columns are removed, then the incorrect colspan is used.
> NavigationToolbar - incorrect static colspan, like NoRecordsToolbar.
> FilterToolbar - same problem as HeadersToolbar, just s/header/filter/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira