You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2013/08/25 21:16:57 UTC
RE: svn commit: r1517192 - /subversion/trunk/build/generator/gen_win_dependencies.py
> -----Original Message-----
> From: jcorvel@apache.org [mailto:jcorvel@apache.org]
> Sent: zaterdag 24 augustus 2013 22:02
> To: commits@subversion.apache.org
> Subject: svn commit: r1517192 -
> /subversion/trunk/build/generator/gen_win_dependencies.py
>
> Author: jcorvel
> Date: Sat Aug 24 20:02:29 2013
> New Revision: 1517192
>
> URL: http://svn.apache.org/r1517192
> Log:
> On Windows, make it possible to build Subversion against Serf 1.3.0 and
> higher by allowing compilation against an already compiled serf.
>
> * build/generator/gen_win_dependencies.py
> (_find_serf): Set is_src to False when version >= 1.3.0.
Not really related to this patch, but more to the log message.
It was already possible to compile against serf 1.3.0 (and serf trunk) by passing the install directory of serf instead of the source directory.
On trunk we accept a standard install directory for almost every dependency now, instead of just source locations. (I think Apache-HttpD is the only remaining exception)
Bert
Re: svn commit: r1517192 - /subversion/trunk/build/generator/gen_win_dependencies.py
Posted by Johan Corveleyn <jc...@gmail.com>.
On Sun, Aug 25, 2013 at 9:16 PM, Bert Huijben <be...@qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: jcorvel@apache.org [mailto:jcorvel@apache.org]
>> Sent: zaterdag 24 augustus 2013 22:02
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1517192 -
>> /subversion/trunk/build/generator/gen_win_dependencies.py
>>
>> Author: jcorvel
>> Date: Sat Aug 24 20:02:29 2013
>> New Revision: 1517192
>>
>> URL: http://svn.apache.org/r1517192
>> Log:
>> On Windows, make it possible to build Subversion against Serf 1.3.0 and
>> higher by allowing compilation against an already compiled serf.
>>
>> * build/generator/gen_win_dependencies.py
>> (_find_serf): Set is_src to False when version >= 1.3.0.
>
> Not really related to this patch, but more to the log message.
>
> It was already possible to compile against serf 1.3.0 (and serf trunk) by passing the install directory of serf instead of the source directory.
>
> On trunk we accept a standard install directory for almost every dependency now, instead of just source locations. (I think Apache-HttpD is the only remaining exception)
>
Oh, okay, I didn't know that.
How should I phrase it in the log message then? Something like: "On
Windows, when compiling subversion against a source directory of serf
1.3.0 (or higher), assume that serf has already been compiled." ?
--
Johan