You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/30 03:14:54 UTC

[GitHub] [spark] gatorsmile opened a new pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

gatorsmile opened a new pull request #28415:
URL: https://github.com/apache/spark/pull/28415


   ### What changes were proposed in this pull request?
   
   This PR is to clean up the markdown file in datetime-pattern page.
   
   - Replace HTML table by MD table
   
   ### Why are the changes needed?
   Make the doc cleaner and easily editable by MD editors.
   
   ### Does this PR introduce _any_ user-facing change?
   NO
   
   ### How was this patch tested?
   **Before**
   ![Screen Shot 2020-04-29 at 7 59 10 PM](https://user-images.githubusercontent.com/11567269/80668093-c9294600-8a55-11ea-9dca-d558203298f8.png)
   
   **After**
   
   ![Screen Shot 2020-04-29 at 8 13 38 PM](https://user-images.githubusercontent.com/11567269/80668146-f1b14000-8a55-11ea-8d47-8dc8a0378271.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621587771


   cc @huaxingao Could you help fix the other similar cases?
   
   I am using this tool to do the conversion: https://jmalarcon.github.io/markdowntables/ 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621591890






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621588406






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621591791


   **[Test build #122104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122104/testReport)** for PR 28415 at commit [`fc18275`](https://github.com/apache/spark/commit/fc18275a4161a708d0eab0e1069148cb2fcc7fbb).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621591890






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on a change in pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #28415:
URL: https://github.com/apache/spark/pull/28415#discussion_r417730878



##########
File path: docs/sql-ref-datetime-pattern.md
##########
@@ -28,194 +28,38 @@ There are several common scenarios for datetime usage in Spark:
 
 Spark uses pattern letters in the following table for date and timestamp parsing and formatting:
 
-<table class="table">
-<tr>
-  <th> <b>Symbol</b> </th>
-  <th> <b>Meaning</b> </th>
-  <th> <b>Presentation</b> </th>
-  <th> <b>Examples</b> </th>
-</tr>
-<tr>
-  <td> <b>G</b> </td>
-  <td> era </td>
-  <td> text </td>
-  <td> AD; Anno Domini; A </td>
-</tr>
-<tr>
-  <td> <b>y</b> </td>
-  <td> year </td>
-  <td> year </td>
-  <td> 2020; 20 </td>
-</tr>
-<tr>
-  <td> <b>D</b> </td>
-  <td> day-of-year </td>
-  <td> number </td>
-  <td> 189 </td>
-</tr>
-<tr>
-  <td> <b>M/L</b> </td>
-  <td> month-of-year </td>
-  <td> number/text </td>
-  <td> 7; 07; Jul; July; J </td>
-</tr>
-<tr>
-  <td> <b>d</b> </td>
-  <td> day-of-month </td>
-  <td> number </td>
-  <td> 28 </td>
-</tr>
-<tr>
-  <td> <b>Q/q</b> </td>
-  <td> quarter-of-year </td>
-  <td> number/text </td>
-  <td> 3; 03; Q3; 3rd quarter </td>
-</tr>
-<tr>
-  <td> <b>Y</b> </td>
-  <td> week-based-year </td>
-  <td> year </td>
-  <td> 1996; 96 </td>
-</tr>
-<tr>
-  <td> <b>w</b> </td>
-  <td> week-of-week-based-year </td>
-  <td> number </td>
-  <td> 27 </td>
-</tr>
-<tr>
-  <td> <b>W</b> </td>
-  <td> week-of-month </td>
-  <td> number </td>
-  <td> 4 </td>
-</tr>
-<tr>
-  <td> <b>E</b> </td>
-  <td> day-of-week </td>
-  <td> text </td>
-  <td> Tue; Tuesday; T </td>
-</tr>
-<tr>
-  <td> <b>u</b> </td>
-  <td> localized day-of-week </td>
-  <td> number/text </td>
-  <td> 2; 02; Tue; Tuesday; T </td>
-</tr>
-<tr>
-  <td> <b>F</b> </td>
-  <td> week-of-month </td>
-  <td> number </td>
-  <td> 3 </td>
-</tr>
-<tr>
-  <td> <b>a</b> </td>
-  <td> am-pm-of-day </td>
-  <td> text </td>
-  <td> PM </td>
-</tr>
-<tr>
-  <td> <b>h</b> </td>
-  <td> clock-hour-of-am-pm (1-12) </td>
-  <td> number </td>
-  <td> 12 </td>
-</tr>
-<tr>
-  <td> <b>K</b> </td>
-  <td> hour-of-am-pm (0-11) </td>
-  <td> number </td>
-  <td> 0 </td>
-</tr>
-<tr>
-  <td> <b>k</b> </td>
-  <td> clock-hour-of-day (1-24) </td>
-  <td> number </td>
-  <td> 0 </td>
-</tr>
-<tr>
-  <td> <b>H</b> </td>
-  <td> hour-of-day (0-23)  </td>
-  <td> number </td>
-  <td> 0 </td>
-</tr>
-<tr>
-  <td> <b>m</b> </td>
-  <td> minute-of-hour </td>
-  <td> number </td>
-  <td> 30 </td>
-</tr>
-<tr>
-  <td> <b>s</b> </td>
-  <td> second-of-minute </td>
-  <td> number </td>
-  <td> 55 </td>
-</tr>
-<tr>
-  <td> <b>S</b> </td>
-  <td> fraction-of-second </td>
-  <td> fraction </td>
-  <td> 978 </td>
-</tr>
-<tr>
-  <td> <b>V</b> </td>
-  <td> time-zone ID </td>
-  <td> zone-id </td>
-  <td> America/Los_Angeles; Z; -08:30 </td>
-</tr>
-<tr>
-  <td> <b>z</b> </td>
-  <td> time-zone name </td>
-  <td> zone-name </td>
-  <td> Pacific Standard Time; PST </td>
-</tr>
-<tr>
-  <td> <b>O</b> </td>
-  <td> localized zone-offset </td>
-  <td> offset-O </td>
-  <td> GMT+8; GMT+08:00; UTC-08:00; </td>
-</tr>
-<tr>
-  <td> <b>X</b> </td>
-  <td> zone-offset 'Z' for zero </td>
-  <td> offset-X </td>
-  <td> Z; -08; -0830; -08:30; -083015; -08:30:15; </td>
-</tr>
-<tr>
-  <td> <b>x</b> </td>
-  <td> zone-offset </td>
-  <td> offset-x </td>
-  <td> +0000; -08; -0830; -08:30; -083015; -08:30:15; </td>
-</tr>
-<tr>
-  <td> <b>Z</b> </td>
-  <td> zone-offset </td>
-  <td> offset-Z </td>
-  <td> +0000; -0800; -08:00; </td>
-</tr>
-<tr>
-  <td> <b>'</b> </td>
-  <td> escape for text </td>
-  <td> delimiter </td>
-  <td></td>
-</tr>
-<tr>
-  <td> <b>''</b> </td>
-  <td> single quote </td>
-  <td> literal </td>
-  <td> ' </td>
-</tr>
-<tr>
-  <td> <b>[</b> </td>
-  <td> optional section start </td>
-  <td>  </td>
-  <td>  </td>
-</tr>
-<tr>
-  <td> <b>]</b> </td>
-  <td> optional section end </td>
-  <td>  </td>
-  <td>  </td>
-</tr>
-</table>
+|Symbol|Meaning|Presentation|Examples|
+|--- |--- |--- |--- |
+|**G**|era|text|AD; Anno Domini; A|

Review comment:
       The tool does not help. 
   
   `**G**` <-- I manually made it **bold**  . 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gatorsmile commented on a change in pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #28415:
URL: https://github.com/apache/spark/pull/28415#discussion_r417730878



##########
File path: docs/sql-ref-datetime-pattern.md
##########
@@ -28,194 +28,38 @@ There are several common scenarios for datetime usage in Spark:
 
 Spark uses pattern letters in the following table for date and timestamp parsing and formatting:
 
-<table class="table">
-<tr>
-  <th> <b>Symbol</b> </th>
-  <th> <b>Meaning</b> </th>
-  <th> <b>Presentation</b> </th>
-  <th> <b>Examples</b> </th>
-</tr>
-<tr>
-  <td> <b>G</b> </td>
-  <td> era </td>
-  <td> text </td>
-  <td> AD; Anno Domini; A </td>
-</tr>
-<tr>
-  <td> <b>y</b> </td>
-  <td> year </td>
-  <td> year </td>
-  <td> 2020; 20 </td>
-</tr>
-<tr>
-  <td> <b>D</b> </td>
-  <td> day-of-year </td>
-  <td> number </td>
-  <td> 189 </td>
-</tr>
-<tr>
-  <td> <b>M/L</b> </td>
-  <td> month-of-year </td>
-  <td> number/text </td>
-  <td> 7; 07; Jul; July; J </td>
-</tr>
-<tr>
-  <td> <b>d</b> </td>
-  <td> day-of-month </td>
-  <td> number </td>
-  <td> 28 </td>
-</tr>
-<tr>
-  <td> <b>Q/q</b> </td>
-  <td> quarter-of-year </td>
-  <td> number/text </td>
-  <td> 3; 03; Q3; 3rd quarter </td>
-</tr>
-<tr>
-  <td> <b>Y</b> </td>
-  <td> week-based-year </td>
-  <td> year </td>
-  <td> 1996; 96 </td>
-</tr>
-<tr>
-  <td> <b>w</b> </td>
-  <td> week-of-week-based-year </td>
-  <td> number </td>
-  <td> 27 </td>
-</tr>
-<tr>
-  <td> <b>W</b> </td>
-  <td> week-of-month </td>
-  <td> number </td>
-  <td> 4 </td>
-</tr>
-<tr>
-  <td> <b>E</b> </td>
-  <td> day-of-week </td>
-  <td> text </td>
-  <td> Tue; Tuesday; T </td>
-</tr>
-<tr>
-  <td> <b>u</b> </td>
-  <td> localized day-of-week </td>
-  <td> number/text </td>
-  <td> 2; 02; Tue; Tuesday; T </td>
-</tr>
-<tr>
-  <td> <b>F</b> </td>
-  <td> week-of-month </td>
-  <td> number </td>
-  <td> 3 </td>
-</tr>
-<tr>
-  <td> <b>a</b> </td>
-  <td> am-pm-of-day </td>
-  <td> text </td>
-  <td> PM </td>
-</tr>
-<tr>
-  <td> <b>h</b> </td>
-  <td> clock-hour-of-am-pm (1-12) </td>
-  <td> number </td>
-  <td> 12 </td>
-</tr>
-<tr>
-  <td> <b>K</b> </td>
-  <td> hour-of-am-pm (0-11) </td>
-  <td> number </td>
-  <td> 0 </td>
-</tr>
-<tr>
-  <td> <b>k</b> </td>
-  <td> clock-hour-of-day (1-24) </td>
-  <td> number </td>
-  <td> 0 </td>
-</tr>
-<tr>
-  <td> <b>H</b> </td>
-  <td> hour-of-day (0-23)  </td>
-  <td> number </td>
-  <td> 0 </td>
-</tr>
-<tr>
-  <td> <b>m</b> </td>
-  <td> minute-of-hour </td>
-  <td> number </td>
-  <td> 30 </td>
-</tr>
-<tr>
-  <td> <b>s</b> </td>
-  <td> second-of-minute </td>
-  <td> number </td>
-  <td> 55 </td>
-</tr>
-<tr>
-  <td> <b>S</b> </td>
-  <td> fraction-of-second </td>
-  <td> fraction </td>
-  <td> 978 </td>
-</tr>
-<tr>
-  <td> <b>V</b> </td>
-  <td> time-zone ID </td>
-  <td> zone-id </td>
-  <td> America/Los_Angeles; Z; -08:30 </td>
-</tr>
-<tr>
-  <td> <b>z</b> </td>
-  <td> time-zone name </td>
-  <td> zone-name </td>
-  <td> Pacific Standard Time; PST </td>
-</tr>
-<tr>
-  <td> <b>O</b> </td>
-  <td> localized zone-offset </td>
-  <td> offset-O </td>
-  <td> GMT+8; GMT+08:00; UTC-08:00; </td>
-</tr>
-<tr>
-  <td> <b>X</b> </td>
-  <td> zone-offset 'Z' for zero </td>
-  <td> offset-X </td>
-  <td> Z; -08; -0830; -08:30; -083015; -08:30:15; </td>
-</tr>
-<tr>
-  <td> <b>x</b> </td>
-  <td> zone-offset </td>
-  <td> offset-x </td>
-  <td> +0000; -08; -0830; -08:30; -083015; -08:30:15; </td>
-</tr>
-<tr>
-  <td> <b>Z</b> </td>
-  <td> zone-offset </td>
-  <td> offset-Z </td>
-  <td> +0000; -0800; -08:00; </td>
-</tr>
-<tr>
-  <td> <b>'</b> </td>
-  <td> escape for text </td>
-  <td> delimiter </td>
-  <td></td>
-</tr>
-<tr>
-  <td> <b>''</b> </td>
-  <td> single quote </td>
-  <td> literal </td>
-  <td> ' </td>
-</tr>
-<tr>
-  <td> <b>[</b> </td>
-  <td> optional section start </td>
-  <td>  </td>
-  <td>  </td>
-</tr>
-<tr>
-  <td> <b>]</b> </td>
-  <td> optional section end </td>
-  <td>  </td>
-  <td>  </td>
-</tr>
-</table>
+|Symbol|Meaning|Presentation|Examples|
+|--- |--- |--- |--- |
+|**G**|era|text|AD; Anno Domini; A|

Review comment:
       The tool does not automatically recognize the style. 
   
   `**G**` <-- I manually made it **bold**  . 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621626101


   thanks, merging to master/3.0!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621588406






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621588011


   **[Test build #122104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122104/testReport)** for PR 28415 at commit [`fc18275`](https://github.com/apache/spark/commit/fc18275a4161a708d0eab0e1069148cb2fcc7fbb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #28415: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28415:
URL: https://github.com/apache/spark/pull/28415#issuecomment-621588011


   **[Test build #122104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122104/testReport)** for PR 28415 at commit [`fc18275`](https://github.com/apache/spark/commit/fc18275a4161a708d0eab0e1069148cb2fcc7fbb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org