[GitHub] [incubator-iceberg] manishmalhotrawork commented on a change in pull request #499: Add persistent IDs to partition fields (WIP)

[GitBox <gi...@apache.org>]

manishmalhotrawork commented on a change in pull request #499: Add persistent IDs to partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r336617583
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
 ##########
 @@ -109,9 +109,9 @@ public int specId() {
       PartitionField field = fields[i];
       Type sourceType = schema.findType(field.sourceId());
       Type resultType = field.transform().getResultType(sourceType);
-      // assign ids for partition fields starting at PARTITION_DATA_ID_START to leave room for data file's other fields
+      // assign ids for partition fields starting at 1000 to leave room for data file's other fields
 
 Review comment:
   let me take care.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org