You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/24 06:48:14 UTC
Review Request: Added a gtest Environment for doing better setup for our
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7714/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac
src/tests/main.cpp 59c727974e91884c1b8b253f3a884520d24c2380
Diff: https://reviews.apache.org/r/7714/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added a gtest Environment for doing better setup for our
tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7714/#review12778
-----------------------------------------------------------
Ship it!
- Ben Mahler
On Oct. 24, 2012, 6:42 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7714/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 6:42 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac
> src/tests/environment.hpp PRE-CREATION
> src/tests/environment.cpp PRE-CREATION
> src/tests/main.cpp 59c727974e91884c1b8b253f3a884520d24c2380
>
> Diff: https://reviews.apache.org/r/7714/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a gtest Environment for doing better setup for our
tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7714/#review12824
-----------------------------------------------------------
Ship it!
src/tests/environment.cpp
<https://reviews.apache.org/r/7714/#comment27473>
new line
src/tests/environment.cpp
<https://reviews.apache.org/r/7714/#comment27474>
kill line
src/tests/main.cpp
<https://reviews.apache.org/r/7714/#comment27475>
naaice
- Vinod Kone
On Oct. 24, 2012, 6:42 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7714/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 6:42 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac
> src/tests/environment.hpp PRE-CREATION
> src/tests/environment.cpp PRE-CREATION
> src/tests/main.cpp 59c727974e91884c1b8b253f3a884520d24c2380
>
> Diff: https://reviews.apache.org/r/7714/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a gtest Environment for doing better setup for our
tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7714/
-----------------------------------------------------------
(Updated Oct. 24, 2012, 6:42 a.m.)
Review request for mesos, Vinod Kone and Ben Mahler.
Changes
-------
Added missing files to the review.
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac
src/tests/environment.hpp PRE-CREATION
src/tests/environment.cpp PRE-CREATION
src/tests/main.cpp 59c727974e91884c1b8b253f3a884520d24c2380
Diff: https://reviews.apache.org/r/7714/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added a gtest Environment for doing better setup for our
tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7714/#review12706
-----------------------------------------------------------
missing a file?
- Jie Yu
On Oct. 24, 2012, 4:48 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7714/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 4:48 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac
> src/tests/main.cpp 59c727974e91884c1b8b253f3a884520d24c2380
>
> Diff: https://reviews.apache.org/r/7714/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>