You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 21:00:51 UTC

[GitHub] [arrow] rok commented on a change in pull request #12507: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`

rok commented on a change in pull request #12507:
URL: https://github.com/apache/arrow/pull/12507#discussion_r814265295



##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -2032,6 +2032,11 @@ def _check_temporal_rounding(ts, values, unit):
         expected = ts.dt.round(frequency)
         np.testing.assert_array_equal(result, expected)
 
+    # Check RoundTemporalOptions defaults
+    result = pc.round_temporal(ta).to_pandas()

Review comment:
       Ugh, sorry I missed that. Follow-up PR: https://github.com/apache/arrow/pull/12511




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org