You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@locus.apache.org on 2000/10/04 14:01:16 UTC
cvs commit: apache-2.0/src/ap ap_buckets_mmap.c
trawick 00/10/04 05:01:15
Modified: src CHANGES
src/ap ap_buckets_mmap.c
Log:
Cleaning up an mmap bucket no longer deletes the mmap. An
mmap can be used across multiple buckets (default_handler with
byte ranges, mod_file_cache, mod_mmap_static), so cleanup of
the mmap itself can't be associated with the bucket.
Prior to this change, mod_file_cache could properly serve a
mmap-ed file only once because the mmap was deleted by
mmap_destroy() when the mmap bucket went away.
Revision Changes Path
1.243 +6 -0 apache-2.0/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /home/cvs/apache-2.0/src/CHANGES,v
retrieving revision 1.242
retrieving revision 1.243
diff -u -r1.242 -r1.243
--- CHANGES 2000/10/04 05:54:14 1.242
+++ CHANGES 2000/10/04 12:01:12 1.243
@@ -1,5 +1,11 @@
Changes with Apache 2.0a7
+ *) Cleaning up an mmap bucket no longer deletes the mmap. An
+ mmap can be used across multiple buckets (default_handler with
+ byte ranges, mod_file_cache, mod_mmap_static), so cleanup of
+ the mmap itself can't be associated with the bucket.
+ [Jeff Trawick]
+
*) Add .dll caching directive ISAPICacheFile to mod_isapi.
[William Rowe]
1.10 +0 -1 apache-2.0/src/ap/ap_buckets_mmap.c
Index: ap_buckets_mmap.c
===================================================================
RCS file: /home/cvs/apache-2.0/src/ap/ap_buckets_mmap.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- ap_buckets_mmap.c 2000/09/11 19:16:59 1.9
+++ ap_buckets_mmap.c 2000/10/04 12:01:14 1.10
@@ -81,7 +81,6 @@
if (m == NULL) {
return;
}
- apr_mmap_delete(m->mmap); /* hope this works! */
free(m);
}