[GitHub] [ignite] timoninmaxim commented on a change in pull request #8600: IGNITE-13882 Add parametrization to ducktape install_root and persistence_root

[GitBox <gi...@apache.org>]

timoninmaxim commented on a change in pull request #8600:
URL: https://github.com/apache/ignite/pull/8600#discussion_r548742396



##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -74,8 +76,22 @@ def config_template(self):
             return IgniteClientConfigTemplate()
         return IgniteServerConfigTemplate()
 
+    def home(self, version=None):

Review comment:
       Let's mark this method and `def module` as private.

##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
##########
@@ -359,8 +378,13 @@ def __update_node_log_file(self, node):
         """
         Update the node log file.
         """
-        cnt = list(node.account.ssh_capture(f'ls {self.LOGS_DIR} | '
-                                            f'grep -E "^console_[0-9]*.log$" | '
+        cnt = list(node.account.ssh_capture(f'ls {self.log_dir} | '
+                                            f'grep -E "^console(_[0-9]+){{0,1}}.log$" | '
                                             f'wc -l', callback=int))[0]
 
-        node.log_file = self.STDOUT_STDERR_CAPTURE.replace('.log', f'_{cnt + 1}.log')
+        node.log_file = os.path.join(self.log_dir, f"console{'_' + str(cnt) if cnt > 0 else ''}.log")
+
+        if cnt > 0:
+            self.logger.debug(f"rotating logs, now logging to {node.log_file} on {node.name}")
+        else:
+            self.logger.debug(f"logging to {node.log_file} on {node.name}")

Review comment:
       Why did you change that? It was exactly like we discussed in Sergey PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org