You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/07/31 06:59:39 UTC

[GitHub] [servicecomb-java-chassis] AngLi2 commented on a change in pull request #1281: [SCB-1402] BeanUtils.getImplClassFromBean can not return correctly in…

AngLi2 commented on a change in pull request #1281: [SCB-1402] BeanUtils.getImplClassFromBean can not return correctly in…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1281#discussion_r309064401
 
 

 ##########
 File path: foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/BeanUtils.java
 ##########
 @@ -110,10 +116,36 @@ public static void setContext(ApplicationContext applicationContext) {
   }
 
   public static Class<?> getImplClassFromBean(Object bean) {
 
 Review comment:
   > Why not call AopProxyUtils.ultimateTargetClass directly?
   
   I am not sure whether should we deal with the 'Advised' case later, so the 'getSingletonTarget' method is copied from AopProxyUtils and put here for later processing.
   Do you think using AopProxyUtils#ultimateTargetClass directly is better? I can change this PR if needed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services