[GitHub] [drill] cgivre commented on a change in pull request #2191: Drill 7882 + Drill 7883 - Fix LGTM Alerts in /common and /contrib

[GitBox <gi...@apache.org>]

cgivre commented on a change in pull request #2191:
URL: https://github.com/apache/drill/pull/2191#discussion_r612090666



##########
File path: contrib/format-xml/src/main/java/org/apache/drill/exec/store/xml/XMLBatchReader.java
##########
@@ -89,9 +89,9 @@ private void openFile(FileScanFramework.FileSchemaNegotiator negotiator) {
       reader = new XMLReader(fsStream, dataLevel, maxRecords);
       reader.open(rootRowWriter, errorContext);
     } catch (Exception e) {
-      throw UserException
+      throw UserException //lgtm[java/unused-format-argument]

Review comment:
       If you've fixed the cause of the lgtm warning, do we still need the comment?

##########
File path: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaPartitionScanSpec.java
##########
@@ -22,7 +22,7 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
 
-public class KafkaPartitionScanSpec {
+public class KafkaPartitionScanSpec { //lgtm[java/inconsistent-equals-and-hashcode]

Review comment:
       We should probably fix this.  Inconsistent equals and hashcode could probably result in weird errors. 

##########
File path: contrib/udfs/src/main/java/org/apache/drill/exec/udfs/NetworkFunctions.java
##########
@@ -431,7 +431,7 @@ public void eval() {
         int power = 3 - i;
         try {
           int ip = Integer.parseInt(ipAddressInArray[i]);
-          result += ip * Math.pow(256, power);
+          result += (long)(ip * Math.pow(256, power)); //lgtm[java/implicit-cast-in-compound-assignment]

Review comment:
       Do we still need the comment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org