[GitHub] [pulsar] lhotari commented on pull request #11753: [pulsar-test] enable pooled netty allocator for unit-tests

[GitBox <gi...@apache.org>]

lhotari commented on pull request #11753:
URL: https://github.com/apache/pulsar/pull/11753#issuecomment-904344206


   It looks like there's a test which isn't compatible with pooled allocator. This test is failing:
   ```
   Error:  Tests run: 7, Failures: 1, Errors: 0, Skipped: 6, Time elapsed: 4.129 s <<< FAILURE! - in org.apache.pulsar.broker.service.TransactionMarkerDeleteTest
   Error:  testMarkerDelete(org.apache.pulsar.broker.service.TransactionMarkerDeleteTest)  Time elapsed: 0.018 s  <<< FAILURE!
   java.lang.UnsupportedOperationException: direct buffer
   	at io.netty.buffer.PooledUnsafeDirectByteBuf.array(PooledUnsafeDirectByteBuf.java:226)
   	at org.apache.pulsar.broker.service.TransactionMarkerDeleteTest.testMarkerDelete(TransactionMarkerDeleteTest.java:122)
   	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
   	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
   	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
   	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
   	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at java.base/java.lang.Thread.run(Thread.java:829)
   ```
   
   It can be fixed by changing [line 108 in TransactionMarkerDeleteTest](https://github.com/apache/pulsar/blob/3fcfb22e71c9774f710d659030d4af01eb05c956/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/TransactionMarkerDeleteTest.java#L108) from `ByteBuf payload = PooledByteBufAllocator.DEFAULT.buffer(0);` to `ByteBuf payload = PooledByteBufAllocator.DEFAULT.heapBuffer(0);`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org