You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2024/04/16 13:40:42 UTC
[PR] AVRO-3978: Upgrade main to build with Java 11 minimum [avro]
jbonofre opened a new pull request, #2855:
URL: https://github.com/apache/avro/pull/2855
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/main/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
Upgrade Avro `main` to build with Java 11 minimum (and remove reference to Java 8).
## Verifying this change
I verified the whole build worked on my machine.
## Documentation
Avro wiki should be updated to mention Avro 1.12.x will be Java 11 minimum, and Avro 1.11.x is still Java 8 compliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3978: Build with Java 11 minimum [avro]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #2855:
URL: https://github.com/apache/avro/pull/2855#issuecomment-2083131275
My gist from the [mail list](https://lists.apache.org/thread/6vbd3w5qk7mpb5lyrfyf2s0z1cymjt5w):
- 1.11.4 will be JDK8+
- 1.12.0 will be JDK11+ (I suggested going to JDK17+ directly since security support has been dropped for JDK11 already, but didn't get a whole lot of replies :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3978: Build with Java 11 minimum [avro]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2855:
URL: https://github.com/apache/avro/pull/2855#issuecomment-2082970623
@martin-g yes for 1.11 but what about 1.12 ? We keep JDK8 for 1.12 as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3978: Build with Java 11 minimum [avro]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #2855:
URL: https://github.com/apache/avro/pull/2855#issuecomment-2059396949
Looks like the integration tests are still relying on JDK8:
```
[INFO] Required toolchain: jdk [ version='8' ]
Error: No toolchain matched from 3 found for type jdk
Error: Cannot find matching toolchain definitions for the following toolchain types:
jdk [ version='8' ]
```
Looks like:
- We want to remove this link: https://github.com/jbonofre/avro/blob/af7b63af762bc2aab442abcae52ca56cba7f86c0/lang/java/pom.xml#L203
- We should update this setting as well: https://github.com/jbonofre/avro/blob/af7b63af762bc2aab442abcae52ca56cba7f86c0/lang/java/interop-data-test/pom.xml#L82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3978: Build with Java 11 minimum [avro]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2855:
URL: https://github.com/apache/avro/pull/2855#issuecomment-2059413982
@Fokko yup, updating it :) Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3978: Build with Java 11 minimum [avro]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2855:
URL: https://github.com/apache/avro/pull/2855#issuecomment-2083156124
👍
Thanks @Fokko !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3978: Build with Java 11 minimum [avro]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #2855:
URL: https://github.com/apache/avro/pull/2855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3978: Build with Java 11 minimum [avro]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2855:
URL: https://github.com/apache/avro/pull/2855#issuecomment-2082939112
@Fokko I will create another PR for JDK11 for avro 1.x branch and update this one for JDK17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3978: Build with Java 11 minimum [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2855:
URL: https://github.com/apache/avro/pull/2855#issuecomment-2082960079
AFAIR 1.11.x should stay with JDK 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org