You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/30 16:38:00 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
viirya opened a new pull request, #2614:
URL: https://github.com/apache/arrow-rs/pull/2614
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2613.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2614:
URL: https://github.com/apache/arrow-rs/pull/2614#issuecomment-1232109101
Benchmark runs are scheduled for baseline = 62eeaa5ebd59ac611b8d17f2fc26373fc30af53f and contender = 9f4d56d53925c61ce99195390b264aa2cca6dac2. 9f4d56d53925c61ce99195390b264aa2cca6dac2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3d045cee22c94cc39d3a673192b1d3c8...7a86bcb92e174808983b31a780dfce0c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bcaa44293335478083278e1bf887a3d8...d0799e96ac994101b85740edb208d413/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/26a90283c1904e1da7d337fbd9e3efe7...c0d2e9a58983419a84712a3921552c9f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b0ce1dca9cd5428bad6562fd5d0200e6...7ccb20bbbdf4465db4c83e01c96cdf88/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #2614:
URL: https://github.com/apache/arrow-rs/pull/2614#issuecomment-1232092148
> Even when the nan_ordering feature is enabled?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2614:
URL: https://github.com/apache/arrow-rs/pull/2614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2614:
URL: https://github.com/apache/arrow-rs/pull/2614#issuecomment-1231915779
Could you perhaps run the benchmarks just to see what performance impact this has?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #2614:
URL: https://github.com/apache/arrow-rs/pull/2614#issuecomment-1232169578
Thanks @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #2614:
URL: https://github.com/apache/arrow-rs/pull/2614#issuecomment-1231932533
Sure. I'll run the benchmark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #2614:
URL: https://github.com/apache/arrow-rs/pull/2614#issuecomment-1232024296
Ran the comparison benchmarks. No performance difference shown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2614: Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2614:
URL: https://github.com/apache/arrow-rs/pull/2614#issuecomment-1232072098
> No performance difference shown.
Even when the nan_ordering feature is enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org