You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/24 12:53:04 UTC
[GitHub] [airflow] krcrouse opened a new pull request, #24636: Fix pid check
krcrouse opened a new pull request, #24636:
URL: https://github.com/apache/airflow/pull/24636
related: #17507
related: #20992
---
This fixes issues in which running a task with impersonation leads to the error `Recorded pid {PID1} does not match the current pid {PID2}`. The issue appears to be that in some cases the recorded pid (which is also the taskinstance pid) is None, which leads the ensuing `psutils.Process(ti.pid).ppid()` call to return the parent of the current running process instead of the parent of the taskinstance.
I was able to reproduce this error regularly and separately traced all processes to try to identify what they were. The "current pid" is the task runner, and in most cases the relevant call was so short lived I couldn't even get it in my tracing - which would explain why it was no longer registered to the task instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] krcrouse commented on pull request #24636: Fix pid check
Posted by GitBox <gi...@apache.org>.
krcrouse commented on PR #24636:
URL: https://github.com/apache/airflow/pull/24636#issuecomment-1177186392
> Is it possible to have a test for this?
I just added a set of tests for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] krcrouse commented on pull request #24636: Fix pid check
Posted by GitBox <gi...@apache.org>.
krcrouse commented on PR #24636:
URL: https://github.com/apache/airflow/pull/24636#issuecomment-1177185927
> Is it possible to have a test for this?
I just added a set of tests for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kagesenshi commented on pull request #24636: Fix pid check
Posted by GitBox <gi...@apache.org>.
kagesenshi commented on PR #24636:
URL: https://github.com/apache/airflow/pull/24636#issuecomment-1170023302
I tried applying this on my 2.2.5 install,
no improvement on my side. Adding a little print logging of `ti.pid` and `psutil.Process(ti.pid).ppid()` shows that they are both different pids (eg: `t.pid` is 51 and `ppid()` is 48. I don't think the is due to the recorded_pid is `None` ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] krcrouse commented on pull request #24636: Fix pid check
Posted by GitBox <gi...@apache.org>.
krcrouse commented on PR #24636:
URL: https://github.com/apache/airflow/pull/24636#issuecomment-1177221679
@kagesenshi, that sounds like a different issue and I haven't seen that one. This specifically addresses when the Task Instance PID is unset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24636: Fix pid check
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24636:
URL: https://github.com/apache/airflow/pull/24636#issuecomment-1165544969
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #24636: Fix pid check
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #24636:
URL: https://github.com/apache/airflow/pull/24636#issuecomment-1167094518
Is it possible to have a test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24636: Fix pid check
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24636:
URL: https://github.com/apache/airflow/pull/24636#issuecomment-1180603590
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24636: Fix pid check
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24636:
URL: https://github.com/apache/airflow/pull/24636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org