You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/06/12 10:37:42 UTC
[GitHub] [hive] aasha opened a new pull request #1099: HIVE-23677 : RetryTest is unstable
aasha opened a new pull request #1099:
URL: https://github.com/apache/hive/pull/1099
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HIVE-XXXXX: Fix a typo in YYY)
For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #1099: HIVE-23677 : RetryTest is unstable
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1099:
URL: https://github.com/apache/hive/pull/1099#issuecomment-643344096
I don't understand,... this change removes the `@Ignore` and allows for exactly one additional millisecond of delay.
Is that one millisecond the fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on pull request #1099: HIVE-23677 : RetryTest is unstable
Posted by GitBox <gi...@apache.org>.
aasha commented on pull request #1099:
URL: https://github.com/apache/hive/pull/1099#issuecomment-643383495
> I don't understand,... this change removes the `@Ignore` and allows for exactly one additional millisecond of delay.
>
> Is that one millisecond the fix?
The test finishes exactly at 180ms. That is why it was failing intermittently with the greater than check. The flaky tests which runs the same test 99 times passed with this fix. http://130.211.9.232/job/hive-flaky-check/28/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk closed pull request #1099: HIVE-23677 : RetryTest is unstable
Posted by GitBox <gi...@apache.org>.
kgyrtkirk closed pull request #1099:
URL: https://github.com/apache/hive/pull/1099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #1099: HIVE-23677 : RetryTest is unstable
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1099:
URL: https://github.com/apache/hive/pull/1099#issuecomment-643384086
Ha. That's crazy it's so exact. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org