You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/10/19 19:01:02 UTC
[GitHub] [kibble] turbaszek opened a new issue #64: Refactor Apache Kibble project
turbaszek opened a new issue #64:
URL: https://github.com/apache/kibble/issues/64
# Refactor Apache Kibble project
This is an umbrella issue for collecting ideas and managing the work that has to be done.
Dev list thread: https://lists.apache.org/thread.html/r3f373be93397fc55ad6aff11030d2f3eb93f0f34782ff58fba9325b1%40%3Cdev.kibble.apache.org%3E
### 1. General refactor
- [ ] Move scanners to main kibble repo
- [ ] Make kibble a package
- [ ] Add command-line interface to configure kibble and start all components (including scanners)
- [ ] Rethink configuration of kibble #52
### 2. Rewrite API server
- [ ] Add tests for API endpoints to help us preserve backward compatibility and to limit the scope of work to backend stuff. The frontend can be done in future. Having the open API spec we should be able to generate some part of required code.
- [ ] Decide which framework we would like to use. The main requirement is that it should work with the existing OpenAPI spec and should do automagically as much as possible.
- [ ] Rewrite all endpoint to use new framework
### Additional considerations
- Consider implementing GraphQL server
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] auvipy commented on issue #64: Refactor Apache Kibble project
Posted by GitBox <gi...@apache.org>.
auvipy commented on issue #64:
URL: https://github.com/apache/kibble/issues/64#issuecomment-713300509
what about considering JSON-API 1.1rc+++ instead of GraphQL server?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] auvipy commented on issue #64: Refactor Apache Kibble project
Posted by GitBox <gi...@apache.org>.
auvipy commented on issue #64:
URL: https://github.com/apache/kibble/issues/64#issuecomment-713400738
ahh :dagger:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] michalslowikowski00 commented on issue #64: Refactor Apache Kibble project
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #64:
URL: https://github.com/apache/kibble/issues/64#issuecomment-716054155
This step: `Make kibble a package` is done. 🚀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on issue #64: Refactor Apache Kibble project
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #64:
URL: https://github.com/apache/kibble/issues/64#issuecomment-713397867
> what about considering JSON-API 1.1rc+++ instead of GraphQL server?
@auvipy thanks for the suggestion! I will take a look at that 👍 But you reminded me that we may also consider running kibble scanners using celery / airflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] skekre98 commented on issue #64: Refactor Apache Kibble project
Posted by GitBox <gi...@apache.org>.
skekre98 commented on issue #64:
URL: https://github.com/apache/kibble/issues/64#issuecomment-715653828
Hi, I would be interested in helping build out the cli for kibble. I have experience building out command line interfaces in Golang as well as Python. Willing to help out wherever needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] skekre98 commented on issue #64: Refactor Apache Kibble project
Posted by GitBox <gi...@apache.org>.
skekre98 commented on issue #64:
URL: https://github.com/apache/kibble/issues/64#issuecomment-716038300
Sure @turbaszek, will finish up _KibbleConfigParser_ and then take a stab at this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek edited a comment on issue #64: Refactor Apache Kibble project
Posted by GitBox <gi...@apache.org>.
turbaszek edited a comment on issue #64:
URL: https://github.com/apache/kibble/issues/64#issuecomment-715889555
> Hi, I would be interested in helping build out the cli for kibble. I have experience building out command line interfaces in Golang as well as Python. Willing to help out wherever needed.
Awesome @skekre98 ! What do you think about using https://click.palletsprojects.com/en/7.x/ ?
The cli should be launched here:
https://github.com/apache/kibble/blob/edb9a91165ff3e3eebbee99db6c86ddf87c362f4/kibble/__main__.py#L18-L23
so users can do `kibble command --flags --and-more`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on issue #64: Refactor Apache Kibble project
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #64:
URL: https://github.com/apache/kibble/issues/64#issuecomment-715889555
> Hi, I would be interested in helping build out the cli for kibble. I have experience building out command line interfaces in Golang as well as Python. Willing to help out wherever needed.
Awesome @skekre98 ! What do you think about using https://click.palletsprojects.com/en/7.x/ ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org