You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/04/06 17:46:18 UTC

[GitHub] [mynewt-nimble] fredster33 opened a new pull request #960: Align logo, grammar updates

fredster33 opened a new pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #960: Align logo, grammar updates

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-814329724


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #960: Align logo, grammar updates

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-818450200


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #960: Align logo, grammar updates

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-814329724


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #960: Align logo, grammar updates

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-818450200


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #960: Align logo, grammar updates

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-843756214


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] fredster33 commented on a change in pull request #960: Align logo, grammar updates

Posted by GitBox <gi...@apache.org>.
fredster33 commented on a change in pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#discussion_r612090238



##########
File path: README.md
##########
@@ -19,22 +19,26 @@
 #
 -->
 
+<div align="center">

Review comment:
       All right, dealigned.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] fredster33 commented on pull request #960: Align logo, grammar updates

Posted by GitBox <gi...@apache.org>.
fredster33 commented on pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-817948962


   Hi, bumping this, any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] utzig commented on a change in pull request #960: Align logo, grammar updates

Posted by GitBox <gi...@apache.org>.
utzig commented on a change in pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#discussion_r612004169



##########
File path: README.md
##########
@@ -19,22 +19,26 @@
 #
 -->
 
+<div align="center">

Review comment:
       I don't like very much the idea of changing the alignment of the logo, and also it won't be the same as for mynewt-core in this PR is merged.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org