You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/06 16:32:31 UTC

[GitHub] [superset] michael-s-molina commented on a diff in pull request #20606: feat(dashboard): Transition to Explore with React Router

michael-s-molina commented on code in PR #20606:
URL: https://github.com/apache/superset/pull/20606#discussion_r915043562


##########
superset/config.py:
##########
@@ -429,6 +429,7 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
     "GENERIC_CHART_AXES": False,
     "ALLOW_ADHOC_SUBQUERY": False,
     "USE_ANALAGOUS_COLORS": True,
+    "DASHBOARD_EDIT_CHART_IN_TAB": True,

Review Comment:
   I can understand the confusion here 😆. I meant `DASHBOARD_EDIT_CHART_IN_NEW_TAB` (added NEW) and this should be `false` by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org