You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/06/24 00:21:08 UTC
Re: Review Request 35806: C++ Scheduler library send Call messages to
Master
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35806/
-----------------------------------------------------------
(Updated June 23, 2015, 10:21 p.m.)
Review request for mesos, Anand Mazumdar, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-2551
https://issues.apache.org/jira/browse/MESOS-2551
Repository: mesos-incubating
Description
-------
Currently, the C++ library sends different messages to Master instead of a single Call message. To vet the new Call API it should send Call messages. Here we update Master to handle all type of Calls.
Diffs
-----
src/master/master.cpp 0782b54
src/scheduler/scheduler.cpp 1efc6fb
Diff: https://reviews.apache.org/r/35806/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 35806: C++ Scheduler library send Call messages to
Master
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35806/#review89095
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35806]
All tests passed.
- Mesos ReviewBot
On June 23, 2015, 10:21 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35806/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 10:21 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2551
> https://issues.apache.org/jira/browse/MESOS-2551
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Currently, the C++ library sends different messages to Master instead of a single Call message. To vet the new Call API it should send Call messages. Here we update Master to handle all type of Calls.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0782b54
> src/scheduler/scheduler.cpp 1efc6fb
>
> Diff: https://reviews.apache.org/r/35806/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 35806: C++ Scheduler library send Call messages to
Master
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35806/#review89091
-----------------------------------------------------------
hey isabel. i would like to take over this patch and add tests. i would also be doing this one call at a time, to be able to test it properly. i'm discarding this review but will likely use it as a reference for my patch set.
- Vinod Kone
On June 23, 2015, 10:21 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35806/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 10:21 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2551
> https://issues.apache.org/jira/browse/MESOS-2551
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Currently, the C++ library sends different messages to Master instead of a single Call message. To vet the new Call API it should send Call messages. Here we update Master to handle all type of Calls.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0782b54
> src/scheduler/scheduler.cpp 1efc6fb
>
> Diff: https://reviews.apache.org/r/35806/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>