You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/24 10:46:36 UTC

[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #263: Fix the bug that the redirection file is not copied when building

tisonkun commented on code in PR #263:
URL: https://github.com/apache/pulsar-site/pull/263#discussion_r1003170041


##########
site2/website-next/scripts/split-version-build.sh:
##########
@@ -76,5 +76,6 @@ done <scripts/.versions
 
 cp -r build-assets/* build/assets/
 rm -rf build-assets
+cp static/.htaccess build/

Review Comment:
   Shall we copy all static files to build here and specially handle the hidden files like `.htaccess`?
   
   In this way, we don't have to specially copy static files in:
   
   https://github.com/apache/pulsar-site/blob/c30db65192c9f1791bf4bd2cf1b300124643933a/site2/tools/build-site.sh#L45-L62



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org