You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/10/22 17:01:38 UTC

[GitHub] [phoenix] gjacoby126 commented on issue #602: PHOENIX-5535 Index rebuilds via UngroupedAggregateRegionObserver shou…

gjacoby126 commented on issue #602: PHOENIX-5535 Index rebuilds via UngroupedAggregateRegionObserver shou…
URL: https://github.com/apache/phoenix/pull/602#issuecomment-545058675
 
 
   @kadirozde - So, I see that you're now having ServerBuildIndexCompiler using PostDDLCompiler rather than PhoenixStatement to generate its query plan -- and given that that's what you're trying to do, the changes make sense. (The extract method on PostDDLCompiler is a good refactoring change even by itself!) 
   
   What's less clear to me is what the purpose of using PostDDLCompiler's AggregatePlan, since the compilation logic is complex and I'm not sure what aspect of it you're relying on. Could you please explain what's the difference, and how did it help fix a permission test issue? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services