[GitHub] [incubator-echarts-bot] plainheart commented on pull request #6: fix: fix `isCoreCommitter` import bug and update a deprecated usage(edit -> update).

[GitBox <gi...@apache.org>]

plainheart commented on pull request #6:
URL: https://github.com/apache/incubator-echarts-bot/pull/6#issuecomment-677986525


   Yes, I think this API changed to `update` from `edit` according to the description in octokit/rest.js#1094 and probot/metadata#15.
   
   We can see a hint from the log that `DEPRECATED (@octokit/rest): issues.edit() is deprecated, use issues.update()` and I can't find `issues.eidt` method any more in the [documentation of octokit](https://octokit.github.io/rest.js/v16#issues-update).
   
   I made some tests in [my repo](https://github.com/plainheart/issue-pr-bot-test/issues/15), the result indicates that both `edit` and `update` are working for me, but it seems to be not working for ECharts. Thus it may be necessary to try the new API.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org