[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38275: [SPARK-40813][CONNECT] Add limit and offset to Connect DSL

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #38275:
URL: https://github.com/apache/spark/pull/38275#discussion_r996886351


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -123,8 +123,16 @@ message Union {
 // Relation of type [[Fetch]] that is used to read `limit` / `offset` rows from the input relation.
 message Fetch {

Review Comment:
   qq why is this Fetch? There are two separate logical plans `Limit` and `Offset`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org