You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/22 07:18:23 UTC
[GitHub] [arrow] AlenkaF opened a new pull request, #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
AlenkaF opened a new pull request, #12952:
URL: https://github.com/apache/arrow/pull/12952
This PR tries to:
- deprecate the `metadata,` `metadata_path` and `common_metadata_path` attributes in the legacy ParquetDataset.
- deprecate passing the `metadata` keyword in the ParquetDataset constructor.
`common_metadata` attribute has already been deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
URL: https://github.com/apache/arrow/pull/12952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #12952:
URL: https://github.com/apache/arrow/pull/12952#discussion_r855971396
##########
python/pyarrow/parquet/__init__.py:
##########
@@ -2031,6 +2037,36 @@ def fs(self):
FutureWarning, stacklevel=2)
return self._metadata.fs
+ @property
+ def metadata_(self):
Review Comment:
Sorted, `metadata` has to be deprecated and not `_metadata`. Thank you Joris!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12952:
URL: https://github.com/apache/arrow/pull/12952#issuecomment-1110163353
Benchmark runs are scheduled for baseline = f23965ceedb403f0f480a0892806f23ab81a2db0 and contender = a16be6b7b6c8271202ff766b99c199b2e29bdfa8. a16be6b7b6c8271202ff766b99c199b2e29bdfa8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c2d5d817520e48b79cce30f90199cc11...80091439fa1e49769f50f0898250d13a/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fcf120a186394a299a378bf60730c03f...87b967bd821e45a1ba84127957feea6c/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a6dd501930444cdf90f2ce67934dd4f7...a01472b10d0a417384611e087cb84107/)
[Finished :arrow_down:0.08% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4e877bf2d81e46ad8904a45f113f7d32...6a0cafcf427d48e3b8ee3d9605e91d5b/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/594| `a16be6b7` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/582| `a16be6b7` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/581| `a16be6b7` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/592| `a16be6b7` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/593| `f23965ce` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/581| `f23965ce` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/579| `f23965ce` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/591| `f23965ce` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #12952:
URL: https://github.com/apache/arrow/pull/12952#discussion_r855980313
##########
python/pyarrow/parquet/__init__.py:
##########
@@ -2031,6 +2037,36 @@ def fs(self):
FutureWarning, stacklevel=2)
return self._metadata.fs
+ @property
+ def metadata(self):
+ """
+ DEPRECATED
+ """
+ warnings.warn(
+ _DEPR_MSG.format("ParquetDataset.metadata_", ""),
Review Comment:
```suggestion
_DEPR_MSG.format("ParquetDataset.metadata", ""),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #12952:
URL: https://github.com/apache/arrow/pull/12952#discussion_r855843725
##########
python/pyarrow/parquet/__init__.py:
##########
@@ -2031,6 +2037,36 @@ def fs(self):
FutureWarning, stacklevel=2)
return self._metadata.fs
+ @property
+ def metadata_(self):
Review Comment:
Had to use something different than `metadata` so I went with `metadata_` - not sure if this is the best approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #12952:
URL: https://github.com/apache/arrow/pull/12952#discussion_r855919679
##########
python/pyarrow/parquet/__init__.py:
##########
@@ -2031,6 +2037,36 @@ def fs(self):
FutureWarning, stacklevel=2)
return self._metadata.fs
+ @property
+ def metadata_(self):
Review Comment:
What's the reason `metadata` doesn't work in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12952:
URL: https://github.com/apache/arrow/pull/12952#issuecomment-1106097017
https://issues.apache.org/jira/browse/ARROW-16121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12952: ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on PR #12952:
URL: https://github.com/apache/arrow/pull/12952#issuecomment-1106253107
There is a `test_parquet_dataset_deprecated_properties` test where you can add the new deprecated ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org