[GitHub] [kafka] viktorsomogyi edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

[GitBox <gi...@apache.org>]

viktorsomogyi edited a comment on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1014401948


   @vlsi you can use other log libraries today as well. The other day I tried out logback runtime (on the broker side) and it works well. All you need is to include logback (or I guess reload4j for that matter) jars runtime and configure it up. I think what we should concentrate on is to be independent from logging frameworks. Kafka has two problems: KafkaLog4JAppender and Log4jController/LoggingResource. The other stuff is mostly testing related to which I say it doesn't really matter, those aren't exposed to production environment anyway. The appender can be replaced by a similar implementation in log4j2 and the controller could be transformed to a pluggable implementation so users won't lose functionality (right know if you switch to logback or something else you won't be able to manipulate log levels dynamically).
   
   As the strongly dependent functionality I think isn't critical and users are mostly free to choose implementation today, I also think it's a good idea to upgrade to log4j2 as a new default. However I think this discussion should be had on the KIP discussion thread, please let us concentrate here on the code review itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org