You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/04/06 02:32:12 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #25018: Update document for checkStyle settings

strongduanmu opened a new pull request, #25018:
URL: https://github.com/apache/shardingsphere/pull/25018

   Ref #24877.
   
   Changes proposed in this pull request:
     - After maven-checkstyle-plugin upgrade to 3.2.1, we need update document for checkStyle settings
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #25018: Update document for checkStyle settings

Posted by "tristaZero (via GitHub)" <gi...@apache.org>.
tristaZero merged PR #25018:
URL: https://github.com/apache/shardingsphere/pull/25018


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on pull request #25018: Update document for checkStyle settings

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #25018:
URL: https://github.com/apache/shardingsphere/pull/25018#issuecomment-1498407513

   We should use checkstyle 9.3 now.
   
   ![image](https://user-images.githubusercontent.com/10829171/230257593-f130203b-6336-48f3-a3ed-202658b82999.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org