You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by micafer <gi...@git.apache.org> on 2017/11/29 12:59:41 UTC

[GitHub] libcloud pull request #1145: Improve error messages in VOMS and OIDC OpenSta...

GitHub user micafer opened a pull request:

    https://github.com/apache/libcloud/pull/1145

    Improve error messages in VOMS and OIDC OpenStackIdentity connectors

    ## Improve error messages in VOMS and OIDC OpenStackIdentity connectors
    
    ### Description
    
    Add response.body as body of the MalformedResponseError to improve error messages in case of non expected response code.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/micafer/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1145
    
----
commit 814bc3e366bdce7f2b935eeb3c7ed21d562cf3e8
Author: micafer <mi...@upv.es>
Date:   2017-06-20T06:21:37Z

    Fix #LIBCLOUD-925

commit 7deee735c43b38e021153579d41193b49cbba1dd
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:37:11Z

    Merge remote-tracking branch 'upstream/trunk' into trunk

commit 00efcf2be242acfa8821dec7c2ec14537a5f9584
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:51:18Z

    Improve error message

----


---

[GitHub] libcloud pull request #1145: Improve error messages in VOMS and OIDC OpenSta...

Posted by micafer <gi...@git.apache.org>.
GitHub user micafer reopened a pull request:

    https://github.com/apache/libcloud/pull/1145

    Improve error messages in VOMS and OIDC OpenStackIdentity connectors

    ## Improve error messages in VOMS and OIDC OpenStackIdentity connectors
    
    ### Description
    
    Add response.body as body of the MalformedResponseError to improve error messages in case of non expected response code.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/micafer/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1145
    
----
commit 814bc3e366bdce7f2b935eeb3c7ed21d562cf3e8
Author: micafer <mi...@upv.es>
Date:   2017-06-20T06:21:37Z

    Fix #LIBCLOUD-925

commit 7deee735c43b38e021153579d41193b49cbba1dd
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:37:11Z

    Merge remote-tracking branch 'upstream/trunk' into trunk

commit 00efcf2be242acfa8821dec7c2ec14537a5f9584
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:51:18Z

    Improve error message

commit e23be01804d4d435382fb2dc2b1bf68ad0f5e401
Author: micafer <mi...@upv.es>
Date:   2017-11-30T08:56:02Z

    Fix LIBCLOUD-965

----


---

[GitHub] libcloud pull request #1145: Improve error messages in VOMS and OIDC OpenSta...

Posted by micafer <gi...@git.apache.org>.
GitHub user micafer reopened a pull request:

    https://github.com/apache/libcloud/pull/1145

    Improve error messages in VOMS and OIDC OpenStackIdentity connectors

    ## Improve error messages in VOMS and OIDC OpenStackIdentity connectors
    
    ### Description
    
    Add response.body as body of the MalformedResponseError to improve error messages in case of non expected response code.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/micafer/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1145
    
----
commit 814bc3e366bdce7f2b935eeb3c7ed21d562cf3e8
Author: micafer <mi...@upv.es>
Date:   2017-06-20T06:21:37Z

    Fix #LIBCLOUD-925

commit 7deee735c43b38e021153579d41193b49cbba1dd
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:37:11Z

    Merge remote-tracking branch 'upstream/trunk' into trunk

commit 00efcf2be242acfa8821dec7c2ec14537a5f9584
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:51:18Z

    Improve error message

----


---

[GitHub] libcloud pull request #1145: [LIBCLOUD-965] /v3/OS-FEDERATION/projects depre...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1145


---

[GitHub] libcloud pull request #1145: [LIBCLOUD-965] /v3/OS-FEDERATION/projects depre...

Posted by micafer <gi...@git.apache.org>.
Github user micafer closed the pull request at:

    https://github.com/apache/libcloud/pull/1145


---

[GitHub] libcloud pull request #1145: Improve error messages in VOMS and OIDC OpenSta...

Posted by micafer <gi...@git.apache.org>.
Github user micafer closed the pull request at:

    https://github.com/apache/libcloud/pull/1145


---

[GitHub] libcloud pull request #1145: [LIBCLOUD-965] /v3/OS-FEDERATION/projects depre...

Posted by micafer <gi...@git.apache.org>.
GitHub user micafer reopened a pull request:

    https://github.com/apache/libcloud/pull/1145

    [LIBCLOUD-965] /v3/OS-FEDERATION/projects deprecated in OpenStack OIDC auth

    ## [LIBCLOUD-965] /v3/OS-FEDERATION/projects deprecated in OpenStack OIDC auth
    
    ### Description
    
    As stated here:
    https://developer.openstack.org/api-ref/identity/v3-ext/#list-projects-a-federated-user-can-access
    
    The path: /v3/OS-FEDERATION/projects has been deprecated in v1.1. Use core GET /auth/projects. This call has the same response format.
    
    Also added response.body as body of the MalformedResponseError to improve error messages in case of non expected response code.
    
    ### Status
    
    - done, ready for review
    Tests are failing due to extenal issues.
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/micafer/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1145
    
----
commit 814bc3e366bdce7f2b935eeb3c7ed21d562cf3e8
Author: micafer <mi...@upv.es>
Date:   2017-06-20T06:21:37Z

    Fix #LIBCLOUD-925

commit 7deee735c43b38e021153579d41193b49cbba1dd
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:37:11Z

    Merge remote-tracking branch 'upstream/trunk' into trunk

commit 00efcf2be242acfa8821dec7c2ec14537a5f9584
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:51:18Z

    Improve error message

commit e23be01804d4d435382fb2dc2b1bf68ad0f5e401
Author: micafer <mi...@upv.es>
Date:   2017-11-30T08:56:02Z

    Fix LIBCLOUD-965

commit 3dd6f4d5aec21f8d11e415fe4d95d2e316bb3dac
Author: micafer <mi...@upv.es>
Date:   2017-11-30T09:59:31Z

    Fix test

----


---

[GitHub] libcloud pull request #1145: [LIBCLOUD-965] /v3/OS-FEDERATION/projects depre...

Posted by micafer <gi...@git.apache.org>.
Github user micafer closed the pull request at:

    https://github.com/apache/libcloud/pull/1145


---

[GitHub] libcloud pull request #1145: Improve error messages in VOMS and OIDC OpenSta...

Posted by micafer <gi...@git.apache.org>.
Github user micafer closed the pull request at:

    https://github.com/apache/libcloud/pull/1145


---

[GitHub] libcloud pull request #1145: [LIBCLOUD-965] /v3/OS-FEDERATION/projects depre...

Posted by micafer <gi...@git.apache.org>.
GitHub user micafer reopened a pull request:

    https://github.com/apache/libcloud/pull/1145

    [LIBCLOUD-965] /v3/OS-FEDERATION/projects deprecated in OpenStack OIDC auth

    ## [LIBCLOUD-965] /v3/OS-FEDERATION/projects deprecated in OpenStack OIDC auth
    
    ### Description
    
    As stated here:
    https://developer.openstack.org/api-ref/identity/v3-ext/#list-projects-a-federated-user-can-access
    
    The path: /v3/OS-FEDERATION/projects has been deprecated in v1.1. Use core GET /auth/projects. This call has the same response format.
    
    Also added response.body as body of the MalformedResponseError to improve error messages in case of non expected response code.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/micafer/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1145
    
----
commit 814bc3e366bdce7f2b935eeb3c7ed21d562cf3e8
Author: micafer <mi...@upv.es>
Date:   2017-06-20T06:21:37Z

    Fix #LIBCLOUD-925

commit 7deee735c43b38e021153579d41193b49cbba1dd
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:37:11Z

    Merge remote-tracking branch 'upstream/trunk' into trunk

commit 00efcf2be242acfa8821dec7c2ec14537a5f9584
Author: micafer <mi...@upv.es>
Date:   2017-11-29T12:51:18Z

    Improve error message

commit e23be01804d4d435382fb2dc2b1bf68ad0f5e401
Author: micafer <mi...@upv.es>
Date:   2017-11-30T08:56:02Z

    Fix LIBCLOUD-965

commit 3dd6f4d5aec21f8d11e415fe4d95d2e316bb3dac
Author: micafer <mi...@upv.es>
Date:   2017-11-30T09:59:31Z

    Fix test

----


---