You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/12 09:56:31 UTC

[GitHub] [inlong] iamsee123 opened a new pull request, #5864: [INLONG-5863][Manager] extend redis extract node

iamsee123 opened a new pull request, #5864:
URL: https://github.com/apache/inlong/pull/5864

   ### Prepare a Pull Request
   
   - Fixes #5863
   ### Motivation
   
   extend redis ExtractNode in Manager module
   
   ### Modifications
   
    Follow the [extend extractNode](https://inlong.apache.org/zh-CN/docs/design_and_concept/how_to_extend_data_node_for_manager)
   + Add RedisSource, RedisSourceDTO, RedisRequestDTO
   + Add Redis type in TaskTypeEnum and SourceType
   + Add RedisSourceOperator
   + Add unit test for Redis source service
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [ ] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [x] This change added tests and can be verified as follows:
   - RedisSourceServiceTest for testing Redis source service
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #5864: [INLONG-5863][Manager] Extend Redis extract node

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5864:
URL: https://github.com/apache/inlong/pull/5864


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] iamsee123 commented on pull request #5864: [INLONG-5863][Manager] Extend Redis extract node

Posted by GitBox <gi...@apache.org>.
iamsee123 commented on PR #5864:
URL: https://github.com/apache/inlong/pull/5864#issuecomment-1248968819

   > > > Maybe miss the part that interacts with the sort protocol？
   > > 
   > > 
   > > I follow the [extend ExtractNode](https://inlong.apache.org/zh-CN/docs/design_and_concept/how_to_extend_data_node_for_manager) guideline. It already had the redis extract node. What I do is add manager plugin thus I add the following classes:RedisSource, RedisSourceDTO, RedisRequestDTO, RedisSourceOperator, add Redis type inTaskTypeEnum and SourceType.
   > 
   > If you want to use it in sort you must implement the protocol of sort with redis, see `org.apache.inlong.manager.pojo.sort.util.ExtractNodeUtils`
   
   Fixed. Thank you for your comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] iamsee123 commented on pull request #5864: [INLONG-5863][Manager] extend redis extract node

Posted by GitBox <gi...@apache.org>.
iamsee123 commented on PR #5864:
URL: https://github.com/apache/inlong/pull/5864#issuecomment-1245205636

   > Maybe miss the part that interacts with the sort protocol？
   
   I follow the [extend ExtractNode](https://inlong.apache.org/zh-CN/docs/design_and_concept/how_to_extend_data_node_for_manager) guideline. It already had the redis extract node. What I do is add manager plugin thus I add the following classes:RedisSource, RedisSourceDTO, RedisRequestDTO, RedisSourceOperator, add Redis type inTaskTypeEnum and SourceType.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] yunqingmoswu commented on pull request #5864: [INLONG-5863][Manager] Extend Redis extract node

Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on PR #5864:
URL: https://github.com/apache/inlong/pull/5864#issuecomment-1248880798

   > If you want to use redis extract node in sort, you must implement the protocol of sort with redis, see `org.apache.inlong.manager.pojo.sort.util.ExtractNodeUtils`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] yunqingmoswu commented on pull request #5864: [INLONG-5863][Manager] Extend Redis extract node

Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on PR #5864:
URL: https://github.com/apache/inlong/pull/5864#issuecomment-1248881910

   > > Maybe miss the part that interacts with the sort protocol？
   > 
   > I follow the [extend ExtractNode](https://inlong.apache.org/zh-CN/docs/design_and_concept/how_to_extend_data_node_for_manager) guideline. It already had the redis extract node. What I do is add manager plugin thus I add the following classes:RedisSource, RedisSourceDTO, RedisRequestDTO, RedisSourceOperator, add Redis type inTaskTypeEnum and SourceType.
   
   If you want to use it in sort you must implement the protocol of sort with redis, see `org.apache.inlong.manager.pojo.sort.util.ExtractNodeUtils`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5864: [INLONG-5863][Manager] Extend Redis extract node

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5864:
URL: https://github.com/apache/inlong/pull/5864#discussion_r971451447


##########
inlong-common/src/main/java/org/apache/inlong/common/enums/TaskTypeEnum.java:
##########
@@ -29,7 +29,8 @@ public enum TaskTypeEnum {
     ORACLE(7),
     SQLSERVER(8),
     MONGODB(9),
-    TUBEMQ(10)
+    TUBEMQ(10),
+    REDIS(11)

Review Comment:
   Please add a comma (,) after `REDIS(11)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org