You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "jiaoqingbo (via GitHub)" <gi...@apache.org> on 2023/02/15 08:58:43 UTC
[GitHub] [incubator-celeborn] jiaoqingbo opened a new pull request, #1240: [CELEBORN-305] Change the parameter passed in the registerShuffle method to numPartitions instead of numMappers
jiaoqingbo opened a new pull request, #1240:
URL: https://github.com/apache/incubator-celeborn/pull/1240
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Change the parameter passed in the registerShuffle method to numPartitions instead of numMappers
### Why are the changes needed?
ShuffleClientImpl's registerShuffle method should pass numPartitions instead of numMappers
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on pull request #1240: [CELEBORN-305] Change the parameter passed in the registerShuffle method to numPartitions instead of numMappers
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #1240:
URL: https://github.com/apache/incubator-celeborn/pull/1240#issuecomment-1431017164
That UT is not stable yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] jiaoqingbo commented on pull request #1240: [CELEBORN-305] Change the parameter passed in the registerShuffle method to numPartitions instead of numMappers
Posted by "jiaoqingbo (via GitHub)" <gi...@apache.org>.
jiaoqingbo commented on PR #1240:
URL: https://github.com/apache/incubator-celeborn/pull/1240#issuecomment-1431009228
The failed UT seems to not related to this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] jiaoqingbo commented on a diff in pull request #1240: [CELEBORN-305] Change the parameter passed in the registerShuffle method to numPartitions instead of numMappers
Posted by "jiaoqingbo (via GitHub)" <gi...@apache.org>.
jiaoqingbo commented on code in PR #1240:
URL: https://github.com/apache/incubator-celeborn/pull/1240#discussion_r1106873499
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -313,7 +313,7 @@ private ConcurrentHashMap<Integer, PartitionLocation> registerShuffle(
return registerShuffleInternal(
shuffleId,
numMappers,
- numMappers,
Review Comment:
Yes, currently this parameter is only used in printing logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1240: [CELEBORN-305] Change the parameter passed in the registerShuffle method to numPartitions instead of numMappers
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1240:
URL: https://github.com/apache/incubator-celeborn/pull/1240#discussion_r1106870978
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -313,7 +313,7 @@ private ConcurrentHashMap<Integer, PartitionLocation> registerShuffle(
return registerShuffleInternal(
shuffleId,
numMappers,
- numMappers,
Review Comment:
Good catch! Although num partitions is actually correctly used when register shuffle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1240: [CELEBORN-305] Change the parameter passed in the registerShuffle method to numPartitions instead of numMappers
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1240:
URL: https://github.com/apache/incubator-celeborn/pull/1240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org