You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sun Dapeng <da...@intel.com> on 2014/08/22 11:43:07 UTC
Review Request 24970: SENTRY-393 Grant/Revoke and Show Grant info
support for column level privilege
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24970/
-----------------------------------------------------------
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
The patch include:
* Remove the limit for column in SentryGrantRevokeTask
* Get column list info in SentryGrantRevokeTask
* Save column list in SentryHivePrivilegeObjectDesc
* SHOW GRANT support and add e2e test for SHOW GRANT
Diffs
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java 49922f9
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 0b26806
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 1b5f557
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java f38ee91
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 8b83859
Diff: https://reviews.apache.org/r/24970/diff/
Testing
-------
Unit tests in local
Thanks,
Sun Dapeng
Re: Review Request 24970: SENTRY-393 Grant/Revoke and Show Grant info
support for column level privilege
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24970/#review60647
-----------------------------------------------------------
Ship it!
Looks fine.
- Prasad Mujumdar
On Oct. 29, 2014, 7:41 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24970/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 7:41 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The patch include:
> * Remove the limit for column in SentryGrantRevokeTask
> * Get column list info in SentryGrantRevokeTask
> * Save column list in SentryHivePrivilegeObjectDesc
> * SHOW GRANT support and add e2e test for SHOW GRANT
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java 6f83cc6
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java ac45746
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 1b5f557
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java f38ee91
> sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 38fa69e
>
> Diff: https://reviews.apache.org/r/24970/diff/
>
>
> Testing
> -------
>
> Unit tests in local
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 24970: SENTRY-393 Grant/Revoke and Show Grant info
support for column level privilege
Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24970/
-----------------------------------------------------------
(Updated εζ 29, 2014, 3:41 p.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
Rebase with master
Repository: sentry
Description
-------
The patch include:
* Remove the limit for column in SentryGrantRevokeTask
* Get column list info in SentryGrantRevokeTask
* Save column list in SentryHivePrivilegeObjectDesc
* SHOW GRANT support and add e2e test for SHOW GRANT
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java 6f83cc6
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java ac45746
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 1b5f557
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java f38ee91
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 38fa69e
Diff: https://reviews.apache.org/r/24970/diff/
Testing
-------
Unit tests in local
Thanks,
Sun Dapeng
Re: Review Request 24970: SENTRY-393 Grant/Revoke and Show Grant info
support for column level privilege
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24970/#review55474
-----------------------------------------------------------
Looks fine.
We should add some more test cases for multiple columns as well as combinitions for table and column privileges. Please feel free to log a followup ticket for adding more test cases.
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java
<https://reviews.apache.org/r/24970/#comment95847>
Nit: Initializing it to an empty list might help to reduce non-null checks in other modules.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java
<https://reviews.apache.org/r/24970/#comment95848>
I think we should also include a test case for privileges on more that one column of a single table
- Prasad Mujumdar
On Sept. 9, 2014, 10:15 a.m., Sun Dapeng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24970/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2014, 10:15 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The patch include:
> * Remove the limit for column in SentryGrantRevokeTask
> * Get column list info in SentryGrantRevokeTask
> * Save column list in SentryHivePrivilegeObjectDesc
> * SHOW GRANT support and add e2e test for SHOW GRANT
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java 6f83cc6
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 4f34de6
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 1b5f557
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java f38ee91
> sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 066e909
>
> Diff: https://reviews.apache.org/r/24970/diff/
>
>
> Testing
> -------
>
> Unit tests in local
>
>
> Thanks,
>
> Sun Dapeng
>
>
Re: Review Request 24970: SENTRY-393 Grant/Revoke and Show Grant info
support for column level privilege
Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24970/
-----------------------------------------------------------
(Updated δΉζ 9, 2014, 6:15 p.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
rebase on SENTRY-407
Repository: sentry
Description
-------
The patch include:
* Remove the limit for column in SentryGrantRevokeTask
* Get column list info in SentryGrantRevokeTask
* Save column list in SentryHivePrivilegeObjectDesc
* SHOW GRANT support and add e2e test for SHOW GRANT
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java 6f83cc6
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 4f34de6
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 1b5f557
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java f38ee91
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 066e909
Diff: https://reviews.apache.org/r/24970/diff/
Testing
-------
Unit tests in local
Thanks,
Sun Dapeng